clean: Remove broken window check #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TextureManager is only being used by the WebGLRenderer, which always runs in the UI thread. Therefore there is no need to check for the environment it runs in. Besides that, the check would throw an error anyways when being evaluated in a worker, since window wouldn't be defined. This check never worked. If we really want to check if we're in a worker, we need to check if "typeof window !== 'undefined".
Member
|
Good call |
Member
|
landed as 51d79f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TextureManager is only being used by the WebGLRenderer, which always runs
in the UI thread. Therefore there is no need to check for the environment it
runs in. Besides that, the check would throw an error anyways when being
evaluated in a worker, since window wouldn't be defined. This check never
worked. If we really want to check if we're in a worker, we need to
check if "typeof window !== 'undefined".
@redwoodfavorite