Clean: Add appropriate docs for getting the WebGL context #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We should not throw if they do not have webGL support and try to use it. |
Contributor
Author
|
Should we just console.log? This refers to the issues that some are having when their system doesn't support WebGL. |
Member
|
Yes, just warn and make sure the code protects from breaking. If you use Mesh you should be able to have the rest of you app work even if WebGL is not enabled. |
Contributor
Author
|
Updated with |
Member
|
Thanks @FarhadG |
Member
|
landed as d32b28a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.