Skip to content

fix: Fix initial glitch (Context solution) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexanderGugel wants to merge 1 commit into from
Closed

fix: Fix initial glitch (Context solution) #265

alexanderGugel wants to merge 1 commit into from

Conversation

@alexanderGugel
Copy link
Member

@alexanderGugel alexanderGugel commented Jun 11, 2015

michaelobriena
michaelobriena reviewed Jun 11, 2015
View reviewed changes
renderers/Compositor.js
Copy link
Member

@michaelobriena michaelobriena Jun 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would really prefer if this was an associated array. This gets called a lot.

Copy link
Member Author

@alexanderGugel alexanderGugel Jun 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, there is actually a TODO in the old code, but I don't think this would belong in this PR. Should I change it?

Copy link
Member

@michaelobriena michaelobriena Jun 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this then change.

@michaelobriena michaelobriena added this to the 0.6.0 milestone Jun 11, 2015
@michaelobriena
Copy link
Member

michaelobriena commented Jun 11, 2015

landed as 90f5784

@alexanderGugel
Copy link
Member Author

alexanderGugel commented Jun 12, 2015

@michaelobriena

Yup.
This doesn't work for nested scenes because of #190 , but should work fine once that has been addressed (can be verified by placing a debugger statement in Context's receive method - the commands should be retrieved at once).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alexanderGugel @michaelobriena