Skip to content

chore: fix broken tests #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelobriena wants to merge 1 commit into from
Closed

chore: fix broken tests #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dom-renderables/test/DOMElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ test('DOMElement', function(t) {
});

t.test('onMount, onUpdate, onDismount lifecyle', function(t) {
t.plan(11);
t.plan(12);

var node = createMockNode(t);
var domElement = new DOMElement(node);
Expand Down Expand Up @@ -238,7 +238,7 @@ test('DOMElement', function(t) {
domElement.onUpdate();
t.deepEqual(
node.sentDrawCommands,
[ 'WITH', 'body/0', 'CHANGE_ATTRIBUTE', 'data-fa-path', '' ],
[ 'WITH', 'body/0', 'CHANGE_ATTRIBUTE', 'data-fa-path', '', 'GL_CUTOUT_STATE', false],
'Dismounting the node should result into the DOMElement being ' +
'hidden'
);
Expand Down
24 changes: 0 additions & 24 deletions dom-renderers/test/DOMRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,30 +264,6 @@ test('DOMRenderer', function(t) {
t.end();
});

t.test('getSize method', function(t) {
var element = document.createElement('div');
var selector = 'selector';
element.classList.add(selector);
var compositor = createUnidirectionalCompositor(t);
var domRenderer = new DOMRenderer(element, selector, compositor);

t.equal(typeof domRenderer.getSize, 'function', 'domRenderer.getSize should be a function');

domRenderer.loadPath(selector + '/' + 0);
domRenderer.findTarget();
domRenderer.insertEl('div');

domRenderer.setSize(true, true);
domRenderer.setContent('some content');

document.body.appendChild(element);
t.notDeepEqual(domRenderer.getSize(), [0, 0]);

document.body.removeChild(element);

t.end();
});

t.test('_triggerEvent method', function(t) {
var element = document.createElement('div');
var selector = 'selector';
Expand Down