Feature systems #281
Closed
Feature systems #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: added more functionality to Path and Transform feature: added object for constant time lookup of nodes by path feature: added functionality to Dispatch feature: added getSelector to pathutilities wip: Node will defer to Dispatch for message passing (beginning with mount and show) chore: added documentation to changes in Dispatch feature: made Dispatch a singleton and refactored code to reflect that chore: linted node chore: lint wip chore: documentation and linting fix: added documentation and removed unused class vars feature: added the ability to request updates for transformsystem feature: Node now uses TransformSystem feature: added deregister method to TransformSystem feature: raced towards working implementation fix: index 15 needs to be 1 fix: High school math fix: DOMRenderer#setContent
wip: added more functionality to Path and Transform feature: added object for constant time lookup of nodes by path feature: added functionality to Dispatch feature: added getSelector to pathutilities wip: Node will defer to Dispatch for message passing (beginning with mount and show) chore: added documentation to changes in Dispatch feature: made Dispatch a singleton and refactored code to reflect that chore: linted node chore: lint wip chore: documentation and linting fix: added documentation and removed unused class vars feature: added the ability to request updates for transformsystem feature: Node now uses TransformSystem feature: added deregister method to TransformSystem feature: raced towards working implementation fix: index 15 needs to be 1 fix: High school math fix: DOMRenderer#setContent refactor: Use cssify instead of inline styles feature: switch -> array + enum feature: added more functions fix: Merge resize listeners refactor: Break out switch statement for receiving commands into separate functions feature: removed switch statement refactor: Convert string based commands to object lookup fix: closer to working with array + enum fix: context resize fix: improper insertion sort feature: small optimizations to renderers/Context fix: Node now properly emits events using the new dispatch test: Fix FamousEngine tests to account for time scaling fix: Remove license headers from json files test: Remove tests for deprecated Node methods fix: fixing format and type options for texture test: Fix DOMElement tests test: Improve DOMElement tests test: Test keyValueToArrays fix: Add famous-dom-element-content styles fix: inserting an el should result in children being appended Properly fix: proper while loop fix: Remove DEFAULT_PROPERTIES chore: renamed getGlobalTransform to getWorldTransform chore: removed dead code fix: Mesh to use new transforms fix: require transformSystem into Mesh fix: WebGl updated to new transform system fix: use alias fix: mount related bugs fix: add camera commands fix: incorrect function signature
It's "deprecated", not "depricated"!
core/SizeSystem.js
Outdated
Member
There was a problem hiding this comment.
@DnMllr size doesn't seem to have a getDifferentialSize() method. Usingnode and changing this to var differentialSize = node.getDifferentialSize(); seems to work well though.
Member
|
Really big 👍 I did some performance testing using 900(!) rotating DIVs. Using the current engine I'd be able to get 2-3FPS whereas this rewrite performs at 55-60(!)FPS Great job @DnMllr ! |
package.json
Outdated
Member
There was a problem hiding this comment.
This is killing the travis build. We do not have a dep on cssify anymore.
There was a problem hiding this comment.
Has this been rebased against develop?
There are regressions in this package json
For example the removal of the tape script
Member
|
Landed in 0.6 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting a cleanup of core that has a few notable features.
This will be ready to merge once it passes travis.
Thanks for everyone's patience.