Fix failure to parse real-world vswhere output#2
Open
slonopotamus wants to merge 2 commits intoFaultyRAM:masterfrom
Open
Fix failure to parse real-world vswhere output#2slonopotamus wants to merge 2 commits intoFaultyRAM:masterfrom
slonopotamus wants to merge 2 commits intoFaultyRAM:masterfrom
Conversation
There are several fields missing that cause failure:
vswhere returned invalid JSON: Error("missing field `productRelease`", line: 40, column: 5)
Note that this commit changes public method signatures, so version is bumped.
slonopotamus
force-pushed
the
optional-fields
branch
from
aac9602 to
074930e
Compare
Author
|
Note that gwihlidal@6008a87 went the different route and completely removes offending fields. If this is a preferred way, I'll update this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several fields missing that cause failure:
Note that this commit changes public method signatures, so version is bumped.
This PR depends on #1.