Skip to content

fix(index): skip version checks for false boolean options#751

Merged
Fdawgs merged 2 commits intomainfrom
fix/version-check
Feb 24, 2026
Merged

fix(index): skip version checks for false boolean options#751
Fdawgs merged 2 commits intomainfrom
fix/version-check

Conversation

@Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Feb 24, 2026

Boolean options set to false are never passed to the underlying binary, so it is redundant doing version checking on them and throwing errors.

Probably a tiny performance boost in here as well.

Checklist

Copilot AI review requested due to automatic review settings February 24, 2026 14:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR avoids performing minVersion validation (and arg building) for boolean options explicitly set to false, since those flags are not passed to the underlying Poppler binaries anyway.

Changes:

  • Update parseOptions() to continue early when encountering boolean options set to false, skipping both arg emission and version checks.
  • Minor refactor of the boolean-option handling logic for clarity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Fdawgs Fdawgs merged commit f0e42f3 into main Feb 24, 2026
21 checks passed
@Fdawgs Fdawgs deleted the fix/version-check branch February 24, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants