fix(index): skip version checks for false boolean options#751
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR avoids performing minVersion validation (and arg building) for boolean options explicitly set to false, since those flags are not passed to the underlying Poppler binaries anyway.
Changes:
- Update
parseOptions()tocontinueearly when encountering boolean options set tofalse, skipping both arg emission and version checks. - Minor refactor of the boolean-option handling logic for clarity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean options set to
falseare never passed to the underlying binary, so it is redundant doing version checking on them and throwing errors.Probably a tiny performance boost in here as well.
Checklist
npm test