Skip to content

Comments

refactor(index): rename constructor param to reflect usage#549

Open
Fdawgs wants to merge 1 commit intomainfrom
chore/path
Open

refactor(index): rename constructor param to reflect usage#549
Fdawgs wants to merge 1 commit intomainfrom
chore/path

Conversation

@Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Feb 24, 2026

Checklist

Copilot AI review requested due to automatic review settings February 24, 2026 18:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors src/index.js to rename the UnRTF constructor parameter and internal private field to reflect that the value represents the directory containing the unrtf binary (not the full binary filepath).

Changes:

  • Rename constructor parameter from binPath to binDir.
  • Rename internal private field from #unrtfPath to #unrtfDir.
  • Update JSDoc to describe the parameter and path getter as a directory path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant