Parse ERB when loading data from YAML files#7
Open
diminish7 wants to merge 2 commits intoFetcher:masterfrom
Open
Parse ERB when loading data from YAML files#7diminish7 wants to merge 2 commits intoFetcher:masterfrom
diminish7 wants to merge 2 commits intoFetcher:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a need we've run into using this gem with time-dependent data, where we've wanted to include, for example, the current date in YAML files we're loading.
This change would allow ERB syntax in YAML, so we can load data like:
In addition, I've updated tests to use rspec 3 syntax to remove deprecation warnings.