Skip to content

Conversation

@hervyt
Copy link
Member

@hervyt hervyt commented Jan 2, 2026

Context

Improve email forms (add request/requests following the number of request, improve logo with dark/light theme and write user's email if firstname or lastname is null/null

How to test

  • Check that when a new_user_in_organization email is sent, there is no "s" on "request" if there is only 1 user, a "s" otherwise
  • Check that logo respect user's theme (dark/light) when sending any type of email
  • Check that if user that request to enter a new organization has "null" fort firstname or lastname, his email is written

Related issues

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

@github-actions github-actions bot added the Filigran Team use to identify PR from the Filigran team label Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 26.91%. Comparing base (7cf7b6e) to head (3cb6894).
⚠️ Report is 3 commits behind head on development.

Files with missing lines Patch % Lines
...rc/modules/services/deployments/deployments.app.ts 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1463      +/-   ##
===============================================
+ Coverage        26.87%   26.91%   +0.03%     
===============================================
  Files              606      606              
  Lines            37271    37314      +43     
  Branches          1780     1784       +4     
===============================================
+ Hits             10017    10043      +26     
- Misses           26979    26996      +17     
  Partials           275      275              
Files with missing lines Coverage Δ
...al-api/src/modules/users/users.organization.app.ts 50.00% <100.00%> (+0.69%) ⬆️
apps/portal-api/src/server/mail-template/mail.ts 91.48% <ø> (ø)
...rc/modules/services/deployments/deployments.app.ts 91.77% <75.00%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf7b6e...3cb6894. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 2m 21s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
22 0 0 23.2s

Suites

22 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 4.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 23.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 24.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 27.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 5.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 2.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 6.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 16.7s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@hervyt hervyt added the needs feature env Indicate if the PR needs an associated feature environment label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filigran Team use to identify PR from the Filigran team needs feature env Indicate if the PR needs an associated feature environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants