[backend] refactor(portalContext): remove dbUnsecure #1476

[carinelebas]

Context

• set requestContext with system_user in auth flow
• remove dbUnsecure (always use db instead)
• remove portalContext from some app parameters

How to test

test there is no regression

Related issues

• Related to [refactor] Remove PortalContext from db function #1476

Checklist

Quality

• I consider this work complete and ready for review
• I tested all features and edge cases
• I refactored code where necessary to improve quality
• I made sure my code meets development guidelines
• I performed a self-review of my code

Testing

• I wrote test cases for the relevant use cases (unit, integration or e2e tests)
• (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

• Unit tests
• Integration tests
• E2E tests
• Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

[codecov]

Codecov Report

❌ Patch coverage is 76.16580% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.67%. Comparing base (935773b) to head (5a2b5c8).
⚠️ Report is 1 commits behind head on development.

Files with missing lines	Patch %	Lines
apps/portal-api/src/server/initialize.helper.ts	44.44%	20 Missing ⚠️
...les/services/registration/registration.resolver.ts	42.85%	4 Missing ⚠️
apps/portal-api/src/auth/auth-platform.ts	50.00%	2 Missing ⚠️
.../portal-api/src/modules/role-portal/role-portal.ts	0.00%	1 Missing and 1 partial ⚠️
...al-api/src/modules/subcription/subscription.app.ts	81.81%	2 Missing ⚠️
apps/portal-api/src/security/auth.helper.ts	50.00%	2 Missing ⚠️
...-api/src/modules/role-portal/role-portal.domain.ts	50.00%	1 Missing ⚠️
...es/custom-dashboards/custom-dashboards.resolver.ts	0.00%	1 Missing ⚠️
...odules/services/document/domain/document.domain.ts	66.66%	1 Missing ⚠️
...les/services/integrations/integrations.resolver.ts	0.00%	1 Missing ⚠️
... and 10 more

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #1479      +/-   ##
===============================================
- Coverage        26.73%   26.67%   -0.06%     
===============================================
  Files              607      607              
  Lines            37864    37817      -47     
  Branches          1794     1790       -4     
===============================================
- Hits             10122    10089      -33     
+ Misses           27466    27452      -14     
  Partials           276      276              

Files with missing lines	Coverage Δ
apps/portal-api/knexfile.ts	89.60% <100.00%> (-0.59%)	⬇️
...ules/common/user-organization-capability.domain.ts	96.42% <100.00%> (-0.13%)	⬇️
...api/src/modules/common/user-organization.domain.ts	62.76% <100.00%> (-2.59%)	⬇️
...api/src/modules/common/user-organization.helper.ts	100.00% <100.00%> (ø)
.../src/modules/organizations/organizations.domain.ts	78.37% <100.00%> (-0.57%)	⬇️
.../src/modules/organizations/organizations.helper.ts	100.00% <100.00%> (ø)
...rc/modules/services/deployments/deployments.app.ts	91.76% <100.00%> (ø)
...les/services/deployments/deployments.test.utils.ts	100.00% <100.00%> (ø)
...i/src/modules/services/document/document.helper.ts	78.04% <100.00%> (ø)
...src/modules/services/document/document.resolver.ts	44.97% <100.00%> (ø)
... and 34 more

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935773b...5a2b5c8. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
22	22	0	0	0	0	2m 18s

Insights

Average Tests per Run	Total Flaky Tests	Total Failed	Slowest Test (p95)
22	0	0	23.7s

Suites

22 passed, 0 failed, and 0 other

Suite	Passed	Failed	Other	Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts         ✅ should prevent user to update another one when he does not have MANAGE_ACCESS         ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION         ✅ should allow user to update another one when he has MANAGE_ACCESS	✅ 3	❌ 0	⏭️ 0	4.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts         ✅ Should add subscription with capabilities	✅ 1	❌ 0	⏭️ 0	23.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts         ✅ Should add CSV Feed         ✅ Should delete CSV Feed from the list         ✅ Should delete CSV Feed from the detailed page	✅ 3	❌ 0	⏭️ 0	23.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts         ✅ Should add custom dashboard         ✅ Should see the custom dashboard on public page         ✅ Should edit a custom dashboard	✅ 3	❌ 0	⏭️ 0	26.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts         ✅ should perform complete CRUD operations on documents	✅ 1	❌ 0	⏭️ 0	4.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts         ✅ should send telemetry event	✅ 1	❌ 0	⏭️ 0	5.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts         ✅ should perform complete CRUD operations on organizations	✅ 1	❌ 0	⏭️ 0	5.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts         ✅ should update user profile information	✅ 1	❌ 0	⏭️ 0	4.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts         ✅ should redirect user between public pages and login page	✅ 1	❌ 0	⏭️ 0	2.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts         ✅ should register openAEV platform         ✅ should register openCTI platform	✅ 2	❌ 0	⏭️ 0	5.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts         ✅ should be able to admin service	✅ 1	❌ 0	⏭️ 0	9.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts         ✅ should be able to add pictures to a service	✅ 1	❌ 0	⏭️ 0	4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts         ✅ Should perform complete CRUD of users as BYPASS         ✅ Should only see authorized users         ✅ Should not edit first and last name as MANAGE_ACCESS user	✅ 3	❌ 0	⏭️ 0	16.4s

_{🎉 No failed tests in this run. | 🍂 No flaky tests in this run.}

Github Test Reporter by CTRF 💚

🔄 This comment has been updated