This repository was archived by the owner on Jun 16, 2018. It is now read-only.
Added support for custom delimiter in team import dialog #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poelstra
reviewed
Aug 25, 2017
Collaborator
poelstra
left a comment
poelstra
left a comment
There was a problem hiding this comment.
Thanks for adding a test! 💯
There are a lot of unrelated changes due to the whitespace. Would be better to put these in a separate commit. (Note that with e.g. git gui, you can stage (and thus commit) individual lines, which makes this very easy to do.)
| } | ||
| lines = lines.map(function(line) { | ||
| lines = lines.map(function (line) { | ||
| if ($scope.useCustomDelimiter) { |
Collaborator
There was a problem hiding this comment.
Unnecessarily complex: just make $scope.delimiter the tab character by default, and always split on $scope.delimiter then.
| <p> | ||
| Use custom delimiter? (Default is tab, the delimiter used when pasting from excel) <br/> | ||
| <input type="checkbox" ng-model="useCustomDelimiter"> | ||
| <input type="text" ng-model="delimiter"> |
Collaborator
There was a problem hiding this comment.
This box should be disabled if useCustomDelimiter is false.
Or, make it a radio-button with Tab (Excel) as first option, and Custom [input field] as second?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the test case is necessary, but I wrote it; Also notice that the message above the custom delim field is really long and spans, which is why it a. is not a label and b. looks bad. So it should probably be shortened.
Solves issue #252 .