This repository was archived by the owner on Jun 16, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Scores seamless sync #277
Open
idanstark42
wants to merge
19
commits into
FirstLegoLeague:master
Choose a base branch
from
idanstark42:scores_seamless_sync
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Scores seamless sync #277
idanstark42
wants to merge
19
commits into
FirstLegoLeague:master
from
idanstark42:scores_seamless_sync
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the only shared functionality between the client and the server, and thereafore it doesn't justify creating a whole platform for code sharing
…d to do it on demand
…ly seamless, and there's no need for the button.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller version of the scores_sync PR #257.
It doesn't contain the code cleaning done in the other PR. Instead, it only contains the code required to achieve the seamless sync of the scores.
Problem: the user need to click buttons for the scores to synchronize between him and the other clients.
Complications: the client must be able to work alone in case the server fails.
Solution: Adding a special service to the client, that is responsible for it's independence (And therefore it's called ng-independence). Upon using it, it will try sending a request to a specified URL, and if it failed, it will keep the request in the browser's local storage, and run a previously specified fallback function. When a request is successful, it will send all saved requests.
The ng-scores then uses this service to make requests to the server, so it will keep it's independence.
In order to create a full sync between the scoresheets and the scores.json, whenever a scoresheet is entered, so does the score entry in the scores.json, and the scoresheets are polled upon server start. That means the scores.json will always be in sync with the scoresheets, even if the server fails mid-process.
And last, for all of this to become possible, and to out rule problems such as information overriding and deadlocks, we use a CRUD API in the server, instead of a stupid server, so that we have one authority to manage the changes to scores.json.