Conversation
zachaysan
left a comment
There was a problem hiding this comment.
Changes look good but please take a look at the linting failures in CI.
Hey @zachaysan - I noticed the failing CI check as well, its failing because it wants me to bump the flagsmith chart version. I bumped it to make it work, but I guess you don't want to be bumping the version of a chart which is not being updated? |
|
Thanks @BennyG93, yeah, this is a similar problem to one that we've been putting off for too long (well, it just exacerbates the problem really). I think it's finally time to integrate release-please here @khvn26 ? Maybe we can merge this PR first and just accept the pointless bump on the flagsmith version though, what do you think? |
|
My 2 cents here, if we merge this PR before that fix/change is made, then I guess whenever you update the main Flagsmith helm chart, it will ask you to bump this proxy chart as well. (and vice versa). So just consider that. The other thing I can do when I have some time is to try and merge the templates of this chart inside the main Flagsmith chart so that it becomes more of an optional sub-component that can be enabled and disabled. With this approach, there will only be 1 chart and you can continue putting off the problem ;) |
Thanks for submitting a PR! Please check the boxes below:
/charts/flagsmith/Chart.yamlin the sectionversionor I'm merging to arelease branch
Changes
Creating a helm chart for deploying the Flagsmith Edge Proxy to Kubernetes.
Explanation:
The chart was initially created using the
helm create...Users can write their proxy configuration in
edgeProxy.configMap.contentor provide the name of an existing configmap that has their configuration toedgeProxy.configMap.name.The chart will create a Volume using this ConfigMap and mount it to each container at the path
/app/config.json.How did you test this code?
We have deployed this chart to our infra.
edgeProxy.configMap.content.helm install -f myvalues.yaml edge-proxy ./edge-proxyThis is an initial attempt, hopefully it provides a solution for anyone who wants to self host the proxy service on Kubernetes.