feat: add state-of-charge sensor to flex-model by victorgarcia98 · Pull Request #1392 · FlexMeasures/flexmeasures

victorgarcia98 · 2025-03-27T10:58:41Z

Description

This PR introduces the field state-of-charge, a sensor to save the state of charge associated with an schedule. In the future, we could use this sensor to get the starting SOC.

Related Items

This PR is based on the work of #1018 but it starts from scratch given the recent changes on multi asset scheduling.

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

nhoening · 2025-03-27T16:26:31Z

So the scheduler saves SoC planning to this sensor, but we are not yet using it for anything else, like a starting SoC?

That should be clearer in the documentation (on schema and CLI)

flexmeasures/cli/data_add.py

flexmeasures/data/schemas/scheduling/storage.py

flexmeasures/data/tests/conftest.py

flexmeasures/data/models/planning/storage.py

flexmeasures/data/tests/test_scheduling_sequential.py

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x

Almost there. Nice that you included the CLI already, too.

flexmeasures/cli/data_add.py

flexmeasures/data/models/planning/storage.py

flexmeasures/data/schemas/scheduling/storage.py

flexmeasures/data/services/scheduling.py

flexmeasures/utils/calculations.py

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Victor <victorgarciareolid98@gmail.com>

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Victor <victorgarciareolid98@gmail.com>

…eature/plannin/save-soc

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x

Nice. This is going to be super helpful. I just found one more potential bug in how the CLI command sets the job kwargs, and please add a changelog entry for 0.26.0.

flexmeasures/cli/data_add.py

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x

🪂

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: api changelog entry for #1392 Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: update main changelog entry for #1392 Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: update month of 0.26 release Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>

feat: add state-of-charge sensor to flex-model

ddc7ff7

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 added enhancement New feature or request Still Needs Changelog Entry labels Mar 27, 2025

victorgarcia98 requested a review from Flix6x March 27, 2025 10:58

victorgarcia98 self-assigned this Mar 27, 2025

nhoening mentioned this pull request Mar 27, 2025

CLI: ability to provide dynamic SoC values from sensor in scheduling #931

Closed

Flix6x requested changes Mar 27, 2025

View reviewed changes

Victor Garcia Reolid added 13 commits April 1, 2025 09:31

add entries to .gitignore

2bce555

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

use SensorIdField

01bd047

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

remove default src unit

b4d45fe

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

check Sensor explicitly

de9fae4

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

fix comment

d889492

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

round soc schedule

635dc59

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

fix: use kwarg for unit

d47dbbf

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

convert SOC

67d19f0

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add traceback message

25b97c9

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

use instantaneous resolution sensor

ebe25b3

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

fix unit conversion

7accf47

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

move default fillna(1) to integrate_time_series

f4201d1

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

check state-of-charge sensor resolution in schema

0597d5f

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 requested a review from Flix6x April 1, 2025 10:39

typo

91ee91b

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

nhoening added this to the 0.26.0 milestone Apr 1, 2025

Flix6x requested changes Apr 1, 2025

View reviewed changes

Victor and others added 5 commits April 2, 2025 00:20

Update flexmeasures/cli/data_add.py

af8357a

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Victor <victorgarciareolid98@gmail.com>

Update flexmeasures/data/models/planning/storage.py

2c9ce16

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Victor <victorgarciareolid98@gmail.com>

remove unnecesarry fillna

1949187

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Update flexmeasures/data/models/planning/storage.py

fb746d8

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Victor <victorgarciareolid98@gmail.com>

Update flexmeasures/data/schemas/scheduling/storage.py

c75519e

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Victor <victorgarciareolid98@gmail.com>

victorgarcia98 requested a review from Flix6x April 1, 2025 22:30

Victor Garcia Reolid added 2 commits April 2, 2025 00:37

Merge remote-tracking branch 'origin/feature/plannin/save-soc' into f…

36da7cc

…eature/plannin/save-soc

apply pre-commit

d5ab294

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x requested changes Apr 1, 2025

View reviewed changes

flexmeasures/cli/data_add.py Outdated Show resolved Hide resolved

flexmeasures/cli/data_add.py Outdated Show resolved Hide resolved

Victor Garcia Reolid added 3 commits April 2, 2025 10:51

fix potential bug

c907022

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

fix state of charge

3ba54f5

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Merge remote-tracking branch 'origin/main' into feature/plannin/save-soc

2008762

Flix6x approved these changes Apr 2, 2025

View reviewed changes

Victor Garcia Reolid added 2 commits April 2, 2025 11:17

add changelog entry

e0ca0d9

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add PR number

f6bde4d

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 merged commit e70878f into main Apr 2, 2025
8 checks passed

victorgarcia98 deleted the feature/plannin/save-soc branch April 2, 2025 11:05

Flix6x removed the Still Needs Changelog Entry label Apr 2, 2025

Flix6x mentioned this pull request Apr 7, 2025

Save SOC values to a sensor #1006

Closed

Flix6x added Scheduling Still Needs Changelog Entry labels Apr 7, 2025

Flix6x added a commit that referenced this pull request Jun 2, 2025

docs: api changelog entry for #1392

08fc573

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x added a commit that referenced this pull request Jun 2, 2025

docs: update main changelog entry for #1392

5ae6c11

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x removed the Still Needs Changelog Entry label Jun 2, 2025

Flix6x mentioned this pull request Sep 18, 2025

Add flex-model field on asset model #1422

Closed

Comments

Conversation

victorgarcia98 commented Mar 27, 2025

Description

Related Items

Uh oh!

nhoening commented Mar 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants