Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 13, 2025

  • Add enableBeeps config flag to config.lua
  • Update PlayBeep function in c_beeps.lua to check the config flag before playing sounds
  • Fix backwards compatibility to assume true when config entry doesn't exist
  • Test the changes by verifying audio can be disabled
  • Code review passed with no issues
  • Security check completed
Original prompt

This section details on the original issue you should resolve

<issue_title>Add config flag to disable audio</issue_title>
<issue_description>https://discord.com/channels/603591936372244501/604451673288474624/1383164913580511263
Image
</issue_description>

<agent_instructions>Add an option for the config.lua to disable audio from the PlayBeep function</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Flohhhhh <48927090+Flohhhhh@users.noreply.github.com>
Copilot AI changed the title [WIP] Add config flag to disable audio functionality Add config flag to disable beep sounds Dec 13, 2025
Copilot AI requested a review from Flohhhhh December 13, 2025 16:52
Copy link
Owner

@Flohhhhh Flohhhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check that this remains backwards compatible, if the entry doesn't exist in the config.lua we will assume true.

Co-authored-by: Flohhhhh <48927090+Flohhhhh@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 13, 2025

Double check that this remains backwards compatible, if the entry doesn't exist in the config.lua we will assume true.

Fixed in 61c611e. Changed from if not Config.enableBeeps to if Config.enableBeeps == false so that nil (missing entry) defaults to enabled beeps.

@Flohhhhh Flohhhhh marked this pull request as ready for review December 13, 2025 17:19
Copilot AI requested a review from Flohhhhh December 13, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add config flag to disable audio

2 participants