Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jul 10, 2025

Update sharee version to 1.1.23, which incorporates a fix for parsagholipour/sharee#7

Summary by CodeRabbit

  • Chores
    • Updated the version of an internal dependency to improve stability and compatibility.
    • Replaced the social media sharing example from "X" platform to Trello in the demo.
    • Removed the outdated "X" platform sharing button configuration from the test suite.
  • New Features
    • Added a method to check link availability in social media sharing drivers.

@javier-godoy javier-godoy requested a review from paodb July 10, 2025 19:37
@coderabbitai
Copy link

coderabbitai bot commented Jul 10, 2025

Walkthrough

The change updates the referenced version of the "sharee" NPM package in the BaseShareEasy Java class from "1.1.20" to "1.1.23". It also removes the NewTwitterDriverOptions class and modifies the SpecialCustomizationsDemo class to replace the "X" (Twitter) custom driver example with a Trello custom driver example, simplifying and correcting demo usage. Additionally, a new hasLink method was added to the driver constructor function in the frontend connector script.

Changes

File(s) Change Summary
src/main/java/com/flowingcode/vaadin/addons/shareeasy/BaseShareEasy.java Updated "sharee" NPM package version from 1.1.20 to 1.1.23
src/test/java/com/flowingcode/vaadin/addons/shareeasy/NewTwitterDriverOptions.java Deleted class defining custom driver options for the "X" (Twitter) sharing button
src/test/java/com/flowingcode/vaadin/addons/shareeasy/SpecialCustomizationsDemo.java Removed third example, replaced "X" custom driver with Trello driver in second example, fixed typo and formatting adjustments
src/main/resources/META-INF/resources/frontend/src/fc-sharee-connector.js Added hasLink() method to driver constructor function inside _addDriver

Possibly related PRs

  • Update Sharee version  #15: Previous update of the "sharee" NPM package version from 1.1.13 to 1.1.20 in the same BaseShareEasy class, directly preceding this version bump.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 871d47e and bbe8ecf.

📒 Files selected for processing (1)
  • src/main/resources/META-INF/resources/frontend/src/fc-sharee-connector.js (1 hunks)
🔇 Additional comments (1)
src/main/resources/META-INF/resources/frontend/src/fc-sharee-connector.js (1)

81-81: Ensure hasLink Is Utilized or Remove It

I searched the codebase and didn’t find any calls to the new hasLink method. Please verify that v1.1.23 of the Sharee library or your connector logic actually uses this helper. If it’s intended to gate calls to getLink, you might:

  • Update getLink to early-return or throw when !this.hasLink().
  • Add tests that cover both presence and absence of driverOptions.link.

Otherwise, consider removing hasLink to avoid dead/unused code.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@paodb
Copy link
Member

paodb commented Jul 18, 2025

When I test this change locally, I see an error in the console and the last demos are not showing as expected:
image

@javier-godoy
Copy link
Member Author

@paodb it was missing the hasLink method that was added in the new version
parsagholipour/sharee@b44aca6#diff-6cc8e1187819dec8cc739978473ed4e9929b5fdae43aa17a6c9480d846e002dbR121

@paodb paodb merged commit 36b03b3 into master Jul 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jul 18, 2025
@paodb paodb deleted the refactor-1.1.23 branch July 18, 2025 19:50
@javier-godoy javier-godoy moved this from Pending release to Done in Flowing Code Addons Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants