Skip to content

Fix to add missing URL encoding in drivers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paodb wants to merge 2 commits into from
Closed

Fix to add missing URL encoding in drivers #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f26bed
fix: add missing encoding for media links
paodb Jul 30, 2025
643494c
refactor: extract driver configuration into _configureDrivers helper
paodb Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 41 additions & 15 deletions src/main/resources/META-INF/resources/frontend/src/fc-sharee-connector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,20 @@ import Sharee from 'sharee';

window.fcShareeConnector = {

create: function (container, optionsJson) {
this._updateXButtonLabel();
this._updateCopyDriverOnClick();
let parsedOptions = JSON.parse(optionsJson);
const sharee = new Sharee(container, parsedOptions);
},
create: function(container, optionsJson) {
this._configureDrivers();
let parsedOptions = JSON.parse(optionsJson);
const sharee = new Sharee(container, parsedOptions);
},

createWithCustomDrivers: function (container, optionsJson) {
this._updateXButtonLabel();
this._updateCopyDriverOnClick();
let parsedOptions = JSON.parse(optionsJson);
// add the custom drivers to the list of drivers
let drivers = parsedOptions.drivers.concat(container.customDrivers);
parsedOptions.drivers = drivers;
const sharee = new Sharee(container, parsedOptions);
},
createWithCustomDrivers: function(container, optionsJson) {
this._configureDrivers();
let parsedOptions = JSON.parse(optionsJson);
// add the custom drivers to the list of drivers
let drivers = parsedOptions.drivers.concat(container.customDrivers);
parsedOptions.drivers = drivers;
const sharee = new Sharee(container, parsedOptions);
},

addCustomDriver(container, customDriverJson) {
if (container.customDrivers == null) {
Expand Down Expand Up @@ -88,6 +86,34 @@ window.fcShareeConnector = {

Sharee.addDriver(name, f);
},

/**
* Configures Sharee drivers by applying required overrides and fixes.
*
* Includes workarounds for missing features and/or known issues in the base library.
* To be revisited if upstream issues are resolved.
*/
_configureDrivers() {
this._updateXButtonLabel();
this._updateSocialShareLinks();
this._updateCopyDriverOnClick();
},

/*
* Workaround because of issue https://github.com/parsagholipour/sharee/issues/8
* (to be removed when issue is fixed)
*/
_updateSocialShareLinks() {
Sharee.drivers['facebook'].prototype.getLink = function() {
return `https://facebook.com/sharer/sharer.php?u=${encodeURIComponent(this.options?.shareLink)}&t=${encodeURIComponent(this.options?.shareText)}`
}
Sharee.drivers['whatsapp'].prototype.getLink = function() {
return `https://wa.me?text=${encodeURIComponent(this.options?.shareText)} \n ${encodeURIComponent(this.options?.shareLink)}`
}
Sharee.drivers['linkedin'].prototype.getLink = function() {
return `https://www.linkedin.com/shareArticle?url=${encodeURIComponent(this.options?.shareLink)}`
}
},

/**
* Replaces onClick function on CopyDriver to take in consideration shareLink option
Expand Down