-
Notifications
You must be signed in to change notification settings - Fork 0
fix: fix JsonObject cast exception in Vaadin 25 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA single dependency version is updated in the Maven configuration file. The json-migration-helper dependency is incremented from version 0.9.1 to 0.9.2. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
11-19: Consider movingjson-migration-helperversion to a property (easier profile overrides / future bumps).
This keeps versioning consistent with the existing${vaadin.version}approach.Proposed diff
<properties> <vaadin.version>24.9.5</vaadin.version> + <json-migration-helper.version>0.9.2</json-migration-helper.version> <maven.compiler.source>17</maven.compiler.source> <maven.compiler.target>17</maven.compiler.target> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> <drivers.dir>${project.basedir}/drivers</drivers.dir> <jetty.version>11.0.26</jetty.version> </properties> @@ <dependency> <groupId>com.flowingcode.vaadin</groupId> <artifactId>json-migration-helper</artifactId> - <version>0.9.2</version> + <version>${json-migration-helper.version}</version> </dependency>Also applies to: 133-136
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-vaadin25
- GitHub Check: build-vaadin24
🔇 Additional comments (1)
pom.xml (1)
133-136: Clarifyjson-migration-helper:0.9.2version and release status before merging.While the root cause is valid—Vaadin 25 removes elemental-json and uses Jackson, causing JsonValue/JsonObject cast exceptions—0.9.2 lacks visible release documentation. Maven Central shows the version in its directory listing, but no GitHub release, tag, or changelog exists. Vaadin's Add-on Directory and MVN Repository only list 0.9.1. Confirm whether 0.9.2 is published (possibly as a direct Maven upload) and whether it includes the fix mentioned in PR #30. If unsure, consider using 0.9.1 pending clarity.



Close #107 (See FlowingCode/JsonMigrationHelper#29, FlowingCode/JsonMigrationHelper#30)
In json-migration-helper 0.9.2
convertToClientCallableResultreturns anObjectNodethat also implementsJsonObjectinstead ofJsonValue.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.