Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jan 12, 2026

Close #107 (See FlowingCode/JsonMigrationHelper#29, FlowingCode/JsonMigrationHelper#30)

In json-migration-helper 0.9.2 convertToClientCallableResult returns an ObjectNode that also implements JsonObject instead of JsonValue.

Summary by CodeRabbit

  • Chores
    • Updated json-migration-helper dependency to version 0.9.2.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

Walkthrough

A single dependency version is updated in the Maven configuration file. The json-migration-helper dependency is incremented from version 0.9.1 to 0.9.2.

Changes

Cohort / File(s) Summary
Dependency Updates
pom.xml
Updated json-migration-helper dependency version from 0.9.1 to 0.9.2

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a JsonObject cast exception in Vaadin 25, which is directly addressed by the dependency version update in pom.xml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pom.xml (1)

11-19: Consider moving json-migration-helper version to a property (easier profile overrides / future bumps).
This keeps versioning consistent with the existing ${vaadin.version} approach.

Proposed diff
 	<properties>
 		<vaadin.version>24.9.5</vaadin.version>
+		<json-migration-helper.version>0.9.2</json-migration-helper.version>
 		<maven.compiler.source>17</maven.compiler.source>
 		<maven.compiler.target>17</maven.compiler.target>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 		<drivers.dir>${project.basedir}/drivers</drivers.dir>
 		<jetty.version>11.0.26</jetty.version>
 	</properties>

@@
 		<dependency>
 			<groupId>com.flowingcode.vaadin</groupId>
 			<artifactId>json-migration-helper</artifactId>
-			<version>0.9.2</version>
+			<version>${json-migration-helper.version}</version>
 		</dependency>

Also applies to: 133-136

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8320193 and 5534de7.

📒 Files selected for processing (1)
  • pom.xml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-vaadin25
  • GitHub Check: build-vaadin24
🔇 Additional comments (1)
pom.xml (1)

133-136: Clarify json-migration-helper:0.9.2 version and release status before merging.

While the root cause is valid—Vaadin 25 removes elemental-json and uses Jackson, causing JsonValue/JsonObject cast exceptions—0.9.2 lacks visible release documentation. Maven Central shows the version in its directory listing, but no GitHub release, tag, or changelog exists. Vaadin's Add-on Directory and MVN Repository only list 0.9.1. Confirm whether 0.9.2 is published (possibly as a direct Maven upload) and whether it includes the fix mentioned in PR #30. If unsure, consider using 0.9.1 pending clarity.

@paodb paodb merged commit 32ca1df into master Jan 12, 2026
3 of 7 checks passed
@paodb paodb deleted the javier-godoy-patch-1 branch January 12, 2026 14:04
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Vaadin 25: ClassCastException

3 participants