Improve Error Handling For Scratch Org Operations #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix panic when accessing empty error message slice by checking length before accessing messages[0] in HTTP response handlers - Handle HTTP 420 status code (scratch org expired) with clear error message instead of dumping HTML response - Fix panic when ScratchOrgInfo fields are nil by using safe type assertions - Poll ScratchOrgInfo until Status is Active before attempting login, with 5 second intervals and 10 minute timeout - Report scratch org creation errors with ErrorCode from ScratchOrgInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic when accessing empty error message slice by checking length before
accessing messages[0] in HTTP response handlers
Handle HTTP 420 status code (scratch org expired) with clear error message
instead of dumping HTML response
Fix panic when ScratchOrgInfo fields are nil by using safe type assertions
Poll ScratchOrgInfo until Status is Active before attempting login, with 5
second intervals and 10 minute timeout
Report scratch org creation errors with ErrorCode from ScratchOrgInfo