Skip to content

fix(mcp-server): log response body on HTTP 500 errors #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Scra3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp-server): log response body on HTTP 500 errors #1460

Scra3 wants to merge 1 commit into from
+208 −1

Conversation

@Scra3
Copy link
Member

@Scra3 Scra3 commented Feb 11, 2026

Summary

  • Enhance interceptResponseForErrorLogging to collect response chunks and log the full body when res.statusCode >= 500
  • Catches plain JSON error responses from the MCP SDK that were previously lost (only SSE-format errors were logged)
  • Add unit tests for sse-error-logger.ts covering SSE error logging, HTTP 500 body logging, and passthrough behavior

Test plan

  • All 15 new tests in sse-error-logger.test.ts pass
  • Full @forestadmin/mcp-server test suite passes (502 tests)
  • Lint passes with no new warnings

🤖 Generated with Claude Code

@claude
fix(mcp-server): log response body on HTTP 500 errors
37f5fe3 
When the MCP SDK writes a 500 response directly (plain JSON, not SSE),
the error details were lost because the existing interceptor only parsed
SSE-format data. This adds chunk collection and HTTP 500+ body logging
so error messages are visible in the logs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@qltysh
Copy link

qltysh bot commented Feb 11, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.05%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: A
packages/mcp-server/src/utils/sse-error-logger.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Scra3