Return HTTPSuccess when HTTP_RESPONSE_DO_NOT_PARSE_BODY_FLAG is set #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the HTTP_RESPONSE_DO_NOT_PARSE_BODY_FLAG is set, the HTTP_PARSING_INCOMPLETE state is expected and valid, as the body data may not yet be received from the transport layer. Previously, this scenario incorrectly returned HTTPInsufficientMemory. This commit corrects the behavior to return HTTPSuccess instead, properly handling the case where body parsing is intentionally deferred. Fixes: FreeRTOS#193 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the HTTP_RESPONSE_DO_NOT_PARSE_BODY_FLAG is set, the HTTP_PARSING_INCOMPLETE state is expected and valid, as the body data may not yet be received from the transport layer.
Previously, this scenario incorrectly returned HTTPInsufficientMemory. This commit corrects the behavior to return HTTPSuccess instead, properly handling the case where body parsing is intentionally deferred.
Test Steps
Ran unit tests.
Checklist:
Related Issue
#193
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.