Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs code cleanup and sanitization, removing unused imports, consolidating duplicate code, and updating shell completions.
Changes:
- Removed unused and redundant imports across multiple Python modules (runners.py, helpers.py, core.py, config.py, cli.py)
- Consolidated duplicate
format_timehelper function by moving it to module level in helpers.py - Bumped version from 0.9.0 to 0.9.1
- Added shell completion support for the
fzlcommand in bash and zsh completion scripts
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fz/runners.py | Removed redundant local imports for os, getpass, and run_command that were already available at module level |
| fz/helpers.py | Moved format_time function to module level and added uuid import at top; removed duplicate local function definitions |
| fz/core.py | Removed unused imports (subprocess, tempfile, io, shutil, Union, Tuple, contextmanager, ThreadPoolExecutor, as_completed); removed unused exception variable; simplified string literals by removing f-string prefix where not needed |
| fz/config.py | Removed unused Union import from typing |
| fz/cli.py | Removed redundant local json imports (already imported at module level) |
| fz/_version.py | Bumped version to 0.9.1 with updated commit date and hash |
| fz/init.py | Updated version string to 0.9.1 |
| completions/fz-completion.zsh | Added fzl command completion support and updated documentation strings |
| completions/fz-completion.bash | Added fzl command completion support and updated documentation strings |
| completions/README.md | Updated documentation to include fzl command in examples and command list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Brief description of what this PR does.
Related Issues
Fixes #(issue number)
Relates to #(issue number)
Type of Change
Changes Made
Testing Performed
Automated Tests
Manual Testing
Test Coverage
# Paste relevant test output or coverage report pytest tests/ -vDocumentation
Code Quality
Breaking Changes
If this is a breaking change:
Screenshots/Examples
(If applicable, add screenshots or example output)
Checklist
Additional Notes
Any additional information reviewers should know.