-
Notifications
You must be signed in to change notification settings - Fork 56
Proper stream parsing in glvis-js #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d73bf98 to
81571bc
Compare
8489de3 to
6371fc7
Compare
|
To be clear, this PR enables general processing, but we cannot distinguish between files and streams in |
|
This is glvis-js compilation with the latest commit: https://github.com/GLVis/glvis-js/actions/runs/21537548572 (branch |
|
@najlkin can you resolve conflict? Also, should this be mentioned in |
|
Done 👍 The latest compilation of glvis-js: https://github.com/GLVis/glvis-js/actions/runs/21602577550 (branch |
|
I just managed to make running and test |
|
Tested and it looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested and looks look good, thanks @najlkin !
This PR unifies handling of streams in JS and glvis app to enable all stream commands, resolving #315.
Moreover, it introduces animations, i.e., time series of solutions.⭐ bonus:
↪️ dependencies: