Refactor importStyleSheet, openSlider and closeSlider following style…#177
Open
sahota8392 wants to merge 1 commit intoGenderMagProject:masterfrom
Open
Refactor importStyleSheet, openSlider and closeSlider following style…#177sahota8392 wants to merge 1 commit intoGenderMagProject:masterfrom
sahota8392 wants to merge 1 commit intoGenderMagProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… guide
name: Pull request template
about: GenderMag Recorders Assistant project
What does this implementation fix? Explain your changes.
-Refactored utilities.js functions -> importStyleSheet, OpenSlider and CloseSlider
Does this close any open issue? (Give issue id from issue tracker)
-No it does not close the issue, it's in progress of refactoring the file to close the issue still.
Include any related logs, error, output file etc.
-N/A
Did you test on Mac and Windows?
-No, refactored the code and submitted a request to understand this is the correct method desired.
Did you test the full GM process and verify that the code does not contribute any unexpected errors/bugs?
-N/A
Did you follow the style guidelines and verify that the code does not have any incorrect formatting?
-Yes, followed the style guideline to try and improve the code
If possible, provide a screenshot of the functionality.
-N/A
Any other information?
-Please provide feedback if this is not the desired result.