Improve CallService lifecycle, notification handling, and ringing-to-active transition

demo-app/src/main/kotlin/io/getstream/video/android/util/StreamVideoInitHelper.kt

@@ -237,7 +237,10 @@ object StreamVideoInitHelper {
         val callServiceConfigRegistry = CallServiceConfigRegistry()
         callServiceConfigRegistry.apply {
             register(DefaultCallConfigurations.getLivestreamGuestCallServiceConfig())
-            register(CallType.AudioCall.name) { enableTelecom(true) }
+            register(
+                CallType.AudioCall.name,
+                DefaultCallConfigurations.audioCall.copy(enableTelecom = true),
+            )
             register(CallType.AnyMarker.name) {
                 setModerationConfig(
                     ModerationConfig(

stream-video-android-core/api/stream-video-android-core.api

@@ -3558,13 +3558,15 @@ public final class io/getstream/android/video/generated/models/ListTranscription
 }
 
 public final class io/getstream/android/video/generated/models/LocalCallMissedEvent : io/getstream/android/video/generated/models/LocalEvent {
-	public fun <init> (Ljava/lang/String;)V
+	public fun <init> (Ljava/lang/String;Ljava/lang/String;)V
 	public final fun component1 ()Ljava/lang/String;
-	public final fun copy (Ljava/lang/String;)Lio/getstream/android/video/generated/models/LocalCallMissedEvent;
-	public static synthetic fun copy$default (Lio/getstream/android/video/generated/models/LocalCallMissedEvent;Ljava/lang/String;ILjava/lang/Object;)Lio/getstream/android/video/generated/models/LocalCallMissedEvent;
+	public final fun component2 ()Ljava/lang/String;
+	public final fun copy (Ljava/lang/String;Ljava/lang/String;)Lio/getstream/android/video/generated/models/LocalCallMissedEvent;
+	public static synthetic fun copy$default (Lio/getstream/android/video/generated/models/LocalCallMissedEvent;Ljava/lang/String;Ljava/lang/String;ILjava/lang/Object;)Lio/getstream/android/video/generated/models/LocalCallMissedEvent;
 	public fun equals (Ljava/lang/Object;)Z
 	public fun getCallCID ()Ljava/lang/String;
 	public final fun getCallCid ()Ljava/lang/String;
+	public final fun getCreatedById ()Ljava/lang/String;
 	public fun getEventType ()Ljava/lang/String;
 	public fun hashCode ()I
 	public fun toString ()Ljava/lang/String;
@@ -7778,6 +7780,7 @@ public final class io/getstream/video/android/core/CallState {
 	public final fun updateFromResponse (Lio/getstream/android/video/generated/models/StartHLSBroadcastingResponse;)V
 	public final fun updateFromResponse (Lio/getstream/android/video/generated/models/StopLiveResponse;)V
 	public final fun updateFromResponse (Lio/getstream/android/video/generated/models/UpdateCallResponse;)V
+	public final fun updateNotification (ILandroid/app/Notification;)V
 	public final fun updateNotification (Landroid/app/Notification;)V
 	public final fun updateParticipant (Lio/getstream/video/android/core/ParticipantState;)V
 	public final fun updateParticipantSortingOrder (Ljava/util/Comparator;)V

stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/LocalCallAcceptedPostEvent.kt

@@ -0,0 +1,59 @@
+/*
+ * Copyright (c) 2014-2024 Stream.io Inc. All rights reserved.
+ *
+ * Licensed under the Stream License;
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://github.com/GetStream/stream-video-android/blob/main/LICENSE
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@file:Suppress(
+    "ArrayInDataClass",
+    "EnumEntryName",
+    "RemoveRedundantQualifierName",
+    "UnusedImport"
+)
+
+package io.getstream.android.video.generated.models
+
+import com.squareup.moshi.Json
+import org.threeten.bp.OffsetDateTime
+
+/**
+ * This event is sent after [CallAcceptedEvent] is consumed in [io.getstream.video.android.core.CallState]
+ */
+
+internal data class LocalCallAcceptedPostEvent (
+    @Json(name = "call_cid")
+    val callCid: String,
+
+    @Json(name = "created_at")
+    val createdAt: OffsetDateTime,
+
+    @Json(name = "call")
+    val call: CallResponse,
+
+    @Json(name = "user")
+    val user: UserResponse,
+
+    @Json(name = "type")
+    val type: String
+)
+: VideoEvent(), WSCallEvent
+{
+
+    override fun getEventType(): String {
+        return type
+    }
+
+    override fun getCallCID(): String {
+        return callCid
+    }    
+}

stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/LocalCallRejectedPostEvent.kt

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2014-2024 Stream.io Inc. All rights reserved.
+ *
+ * Licensed under the Stream License;
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://github.com/GetStream/stream-video-android/blob/main/LICENSE
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@file:Suppress(
+    "ArrayInDataClass",
+    "EnumEntryName",
+    "RemoveRedundantQualifierName",
+    "UnusedImport"
+)
+
+package io.getstream.android.video.generated.models
+
+import com.squareup.moshi.Json
+import org.threeten.bp.OffsetDateTime
+
+/**
+ * This event is sent after [CallRejectedEvent] is consumed in [io.getstream.video.android.core.CallState]
+ */
+
+internal data class LocalCallRejectedPostEvent (
+    @Json(name = "call_cid")
+    val callCid: String,
+
+    @Json(name = "created_at")
+    val createdAt: OffsetDateTime,
+
+    @Json(name = "call")
+    val call: CallResponse,
+
+    @Json(name = "user")
+    val user: UserResponse,
+
+    @Json(name = "type")
+    val type: String,
+
+    @Json(name = "reason")
+    val reason: String? = null
+)
+: VideoEvent(), WSCallEvent
+{
+
+    override fun getEventType(): String {
+        return type
+    }
+
+    override fun getCallCID(): String {
+        return callCid
+    }    
+}

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt

@@ -463,6 +463,12 @@ public class Call(
         }
 
         response.onSuccess {
+            /**
+             * Because [CallState.updateFromResponse] reads the value of [ClientState.ringingCall]
+             */
+            if (ring) {
+                client.state._ringingCall.value = this
+            }
             state.updateFromResponse(it)
             if (ring) {
                 client.state.addRingingCall(this, RingingState.Outgoing())
@@ -929,7 +935,6 @@ public class Call(
     }
 
     private fun internalLeave(disconnectionReason: Throwable?, reason: String) = atomicLeave {
-        val callId = id
         monitorSubscriberPCStateJob?.cancel()
         monitorPublisherPCStateJob?.cancel()
         monitorPublisherPCStateJob = null
@@ -1535,8 +1540,7 @@ public class Call(
         logger.d { "[accept] #ringing; no args, call_id:$id" }
         state.acceptedOnThisDevice = true
 
-        clientImpl.state.removeRingingCall(this)
-        clientImpl.state.maybeStopForegroundService(call = this)
+        clientImpl.state.transitionToAcceptCall(this)
         return clientImpl.accept(type, id)
     }
 

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt

@@ -20,6 +20,7 @@ import android.app.Notification
 import android.os.Bundle
 import android.util.Log
 import androidx.compose.runtime.Stable
+import androidx.core.app.NotificationManagerCompat
 import io.getstream.android.video.generated.models.BlockedUserEvent
 import io.getstream.android.video.generated.models.CallAcceptedEvent
 import io.getstream.android.video.generated.models.CallClosedCaption
@@ -33,6 +34,7 @@ import io.getstream.android.video.generated.models.CallMemberAddedEvent
 import io.getstream.android.video.generated.models.CallMemberRemovedEvent
 import io.getstream.android.video.generated.models.CallMemberUpdatedEvent
 import io.getstream.android.video.generated.models.CallMemberUpdatedPermissionEvent
+import io.getstream.android.video.generated.models.CallMissedEvent
 import io.getstream.android.video.generated.models.CallModerationBlurEvent
 import io.getstream.android.video.generated.models.CallParticipantResponse
 import io.getstream.android.video.generated.models.CallReactionEvent
@@ -63,7 +65,9 @@ import io.getstream.android.video.generated.models.GetOrCreateCallResponse
 import io.getstream.android.video.generated.models.GoLiveResponse
 import io.getstream.android.video.generated.models.HealthCheckEvent
 import io.getstream.android.video.generated.models.JoinCallResponse
+import io.getstream.android.video.generated.models.LocalCallAcceptedPostEvent
 import io.getstream.android.video.generated.models.LocalCallMissedEvent
+import io.getstream.android.video.generated.models.LocalCallRejectedPostEvent
 import io.getstream.android.video.generated.models.MemberResponse
 import io.getstream.android.video.generated.models.MuteUsersResponse
 import io.getstream.android.video.generated.models.OwnCapability
@@ -109,6 +113,7 @@ import io.getstream.video.android.core.model.ScreenSharingSession
 import io.getstream.video.android.core.model.VisibilityOnScreenState
 import io.getstream.video.android.core.moderations.ModerationManager
 import io.getstream.video.android.core.notifications.IncomingNotificationData
+import io.getstream.video.android.core.notifications.NotificationType
 import io.getstream.video.android.core.notifications.internal.service.CallServiceConfig
 import io.getstream.video.android.core.notifications.internal.telecom.jetpack.JetpackTelecomRepository
 import io.getstream.video.android.core.permission.PermissionRequest
@@ -122,6 +127,7 @@ import io.getstream.video.android.core.utils.TaskSchedulerWithDebounce
 import io.getstream.video.android.core.utils.mapState
 import io.getstream.video.android.core.utils.safeCall
 import io.getstream.video.android.core.utils.toUser
+import io.getstream.video.android.model.StreamCallId
 import io.getstream.video.android.model.User
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Job
@@ -699,6 +705,7 @@ public class CallState(
      */
     internal val atomicNotification: AtomicReference<Notification?> =
         AtomicReference<Notification?>(null)
+    internal var notificationId: Int? = null
 
     @InternalStreamVideoApi
     internal var jetpackTelecomRepository: JetpackTelecomRepository? = null
@@ -707,6 +714,7 @@ public class CallState(
 
     fun handleEvent(event: VideoEvent) {
         logger.d { "[handleEvent] ${event::class.java.name.split(".").last()}" }
+
         when (event) {
             is BlockedUserEvent -> {
                 val newBlockedUsers = _blockedUsers.value.toMutableSet()
@@ -747,9 +755,23 @@ public class CallState(
                     // Then leave the call on this device
                     if (!acceptedOnThisDevice) call.leave("accepted-on-another-device")
                 }
+                call.fireEvent(
+                    LocalCallAcceptedPostEvent(
+                        event.callCid,
+                        event.createdAt,
+                        event.call,
+                        event.user,
+                        event.type,
+                    ),
+                )
+            }
+
+            is CallMissedEvent -> {
+                _createdBy.value = event.call.createdBy.toUser()
             }
 
             is CallRejectedEvent -> {
+                _createdBy.value = event.call.createdBy.toUser()
                 val new = _rejectedBy.value.toMutableSet()
                 new.add(event.user.id)
                 _rejectedBy.value = new.toSet()
@@ -763,6 +785,16 @@ public class CallState(
                         }
                     },
                 )
+                call.fireEvent(
+                    LocalCallRejectedPostEvent(
+                        event.callCid,
+                        event.createdAt,
+                        event.call,
+                        event.user,
+                        event.type,
+                        event.reason,
+                    ),
+                )
             }
 
             is LocalCallMissedEvent -> {
@@ -774,6 +806,17 @@ public class CallState(
                     _rejectedBy.value = newRejectedBySet.toSet()
                     _ringingState.value = RingingState.RejectedByAll
                     call.leave("LocalCallMissedEvent")
+
+                    val activeCallExists = client.state.activeCall.value != null
+                    if (activeCallExists) {
+                        // Another call is active - just remove incoming notification
+                        val streamCallId = StreamCallId(call.type, call.id)
+                        NotificationManagerCompat.from(client.context)
+                            .cancel(streamCallId.getNotificationId(NotificationType.Incoming))
+                    } else {
+                        // No other call - stop service
+                        client.state.maybeStopForegroundService(call)
+                    }
                 }
             }
 
@@ -1645,9 +1688,15 @@ public class CallState(
         _rejectActionBundle.value = bundle
     }
 
+    @Deprecated("Use updateNotification(Int, Notification) instead")
     fun updateNotification(notification: Notification) {
         atomicNotification.set(notification)
     }
+
+    fun updateNotification(notificationId: Int, notification: Notification) {
+        this.notificationId = notificationId
+        this.atomicNotification.set(notification)
+    }
 }
 
 private fun MemberResponse.toMemberState(): MemberState {