Skip to content

fix: new_text_message() may create messages with empty contents #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IthacaDream wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: new_text_message() may create messages with empty contents #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8adff
fix: new_text_message() may create messages with empty contents
IthacaDream Feb 18, 2026
79d2cbb
imporved hard-coded assertions in test cases
IthacaDream Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ghoshell_moss/message/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ def new_text_message(content: str, *, role: str | Role = "") -> Message:
"""
创建一个系统消息.
"""
meta = MessageMeta(role=str(role))
meta = MessageMeta(role=role.value if isinstance(role, Role) else str(role))
obj = Text(text=content)
return Message(meta=meta).as_completed([obj.to_content()])
return Message(meta=meta, seq="head").as_completed([obj.to_content()])
3 changes: 3 additions & 0 deletions tests/channels/test_py_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from ghoshell_moss.core.concepts.command import CommandTask, PyCommand
from ghoshell_moss.core.py_channel import PyChannel
from ghoshell_moss.message import Message, new_text_message
from ghoshell_moss.message.contents import Text

chan = PyChannel(name="test")

Expand Down Expand Up @@ -219,3 +220,5 @@ def foo() -> list[Message]:
# 更新后, messages 也变更了.
await broker.refresh_meta()
assert len(broker.meta().context) == 2
assert broker.meta().context[0].contents[0] == Text(text="hello").to_content()
assert broker.meta().context[1].contents[0] == Text(text="world").to_content()
Loading