Skip to content

Cp branch#8664

Open
iam-sakshi wants to merge 8 commits intoGirlScript:Competitive_Programmingfrom
iam-sakshi:cp_branch
Open

Cp branch#8664
iam-sakshi wants to merge 8 commits intoGirlScript:Competitive_Programmingfrom
iam-sakshi:cp_branch

Conversation

@iam-sakshi
Copy link
Contributor

@iam-sakshi iam-sakshi commented Nov 27, 2021

Description 📜

few ways to escape TLE in CP with C++
TLE in C++ #8663

Type of change 📝

  • Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
  • Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
  • Doc#umentation (Content Creation in the form of codes or tutorials)
  • Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

  • Android Dev #(Flutter)
  • Android Dev #(Java)
  • Android Dev #(Kotlin)
  • Backend Dev #(Java)
  • Backend Dev #(.NET)
  • Backend Dev #(PHP)
  • Backend Dev #(Python)
  • C/#CPP
  • Competitive #Programming
  • Cyber #Security
  • DS#A
  • Data#base
  • Datascience with #Python
  • Datascience with #R
  • Frontend Dev #HTML/CSS/JS
  • Frontend Dev #React/Angular/Vue
  • Go#lang
  • Interview #Prep
  • Java_#Domain
  • JavaScript_#Domain
  • ME#RN
  • Machine #Learning
  • Open #Source
  • Python_#Domain
  • Ru#st
  • Statis#tics
  • UI/#UX

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

iam-sakshi and others added 7 commits November 27, 2021 13:24
@iam-sakshi @priyankapiba
@Jinal4502 @ErzaTitania-2001
Competitive programming (#8)
a75af53 
* Merge two arrays according to constraints added.

* Create MagicNumber.md

* Rename MagicNumber.md to NthMagicNumber.md

* header file and heading added.

* Rename Competitive_Programming/Python/Maths & Number Theory/MagicNumber/NthMagicNumber.md to Competitive_Programming/Python/Maths & Number Theory/NthMagicNumber/NthMagicNumber.md

Co-authored-by: BootLook <73538645+priyankapiba@users.noreply.github.com>
Co-authored-by: Jinal4502 <65852362+Jinal4502@users.noreply.github.com>
Co-authored-by: Ahana Pal <59911272+ErzaTitania-2001@users.noreply.github.com>
@iam-sakshi @priyankapiba
@Jinal4502 @ErzaTitania-2001
Competitive programming (#10)
322bc48 
* Merge two arrays according to constraints added.

* Create MagicNumber.md

* Rename MagicNumber.md to NthMagicNumber.md

* header file and heading added.

* Rename Competitive_Programming/Python/Maths & Number Theory/MagicNumber/NthMagicNumber.md to Competitive_Programming/Python/Maths & Number Theory/NthMagicNumber/NthMagicNumber.md

Co-authored-by: BootLook <73538645+priyankapiba@users.noreply.github.com>
Co-authored-by: Jinal4502 <65852362+Jinal4502@users.noreply.github.com>
Co-authored-by: Ahana Pal <59911272+ErzaTitania-2001@users.noreply.github.com>
@iam-sakshi
Delete Merge-two-arrays.md
9f05397
@iam-sakshi
Delete Competitive_Programming/Python/Maths & Number Theory/NthMagicN…
c7ed738 
…umber directory
@iam-sakshi
Create TopKthFrequentElement.md
6ef87fb
@iam-sakshi
Create TLE.md
39a05e2
@iam-sakshi
Delete TopKthFrequentElement.md
7aae5e8
@iam-sakshi
Copy link
Contributor Author

iam-sakshi commented Nov 27, 2021

@ravireddy07 please review

@ravireddy07
Copy link
Contributor

ravireddy07 commented Nov 28, 2021

See @iam-sakshi I can't explain the same thing. As you can see, there are commits which already merged are present in this PR. You can just update your local branch which you raised this PR with the Competitive_Programming branch. That's it.
You can even follow the steps which i shared.

See, approving and merging is completely fine and it's bad practice for me to approve this kind of PR and bad practice for you to raise this kind of PR(s). This won't be a problem in this kind of projects, but it's a bad practice and might raise issues in other product based projects where each commit significes a change in the product/feature.

That's all i can say. It's you're wish to learn or not. :)(

ravireddy07
ravireddy07 suggested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@ravireddy07 ravireddy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the following things:

  • Remove spaces in folder name and update the TLE to it's full form.
  • Please add few more points like cout and '\n'...etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ravireddy07 ravireddy07 ravireddy07 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

GWOC21

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iam-sakshi @ravireddy07