fix: use correct connection name in getFieldsFromConn #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where table field generation returns empty fields array when using multiple database connections with non-default connection.
Problem
When using
adm generatewith a non-default database connection (e.g.connection = "business"), the generated table model file contains no fields.The issue is in
getFieldsFromConn()function inplugins/admin/modules/tools/generator.goline 444.Root Cause
always sets
sql.conn = "default"internally, ignoring theconnNameparameter. This causes the query to execute on the wrong database connection.Solution
Use
WithDriverAndConnection(connName, conn)instead to respect the specified connection name:Testing
Tested with the following configuration:
[database]
driver = mysql
name = goadmin
[database.business]
driver = mysql
name = business