Skip to content

Fix Android package compatibility across ABIs#8

Open
GooGuJiang wants to merge 4 commits intomasterfrom
codex/fix-installation-failure-for-android-apk
Open

Fix Android package compatibility across ABIs#8
GooGuJiang wants to merge 4 commits intomasterfrom
codex/fix-installation-failure-for-android-apk

Conversation

@GooGuJiang
Copy link
Collaborator

@GooGuJiang GooGuJiang commented Sep 17, 2025

Summary

  • expand the Android runtime identifier list to cover arm64, armv7, x86, and x86_64
  • package all supported ABIs into a single APK so GitHub builds remain installable on real devices

Testing

  • ⚠️ dotnet build osu.Desktop/osu.Desktop.csproj -c Release (fails: dotnet is not available in the execution environment)

https://chatgpt.com/codex/tasks/task_e_68c9f5d229748331947c77078692107d

Summary by Sourcery

Expand Android ABI support and produce a universal APK for all architectures

Enhancements:

  • Add arm64, armv7, x86, and x86_64 to the Android runtime identifiers list
  • Configure the build to produce a single APK containing all supported ABIs

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR broadens the Android build to include arm64-v8a, armeabi-v7a, x86, and x86_64 in the RuntimeIdentifiers and configures the project to bundle all supported ABIs into a single universal APK.

File-Level Changes

Change Details Files
Expand Android runtime identifiers to cover all target ABIs
  • Add arm64-v8a, armeabi-v7a, x86, and x86_64 entries to the RuntimeIdentifiers property
  • Update AndroidSupportedAbis list to match the expanded RuntimeIdentifiers
osu.Android.props
Configure packaging to produce a single multi-ABI APK
  • Set AndroidPackageAbis property to include all supported ABIs
  • Adjust packaging format settings to bundle all ABIs into one APK output
osu.Android.props

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Packaging all ABIs into a single APK can significantly increase the download size; consider using split APKs or an Android App Bundle (AAB) to optimize delivery per architecture.
  • Verify that the AndroidSupportedAbis setting actually produces a .apk containing native libraries for armeabi-v7a, arm64-v8a, x86, and x86_64 under lib/ directories to avoid missing native libs at runtime.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Packaging all ABIs into a single APK can significantly increase the download size; consider using split APKs or an Android App Bundle (AAB) to optimize delivery per architecture.
- Verify that the AndroidSupportedAbis setting actually produces a .apk containing native libraries for armeabi-v7a, arm64-v8a, x86, and x86_64 under lib/ directories to avoid missing native libs at runtime.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant