Fix Android package compatibility across ABIs#8
Open
GooGuJiang wants to merge 4 commits intomasterfrom
Open
Conversation
Fix Android runtime identifier to produce compatible APKs
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR broadens the Android build to include arm64-v8a, armeabi-v7a, x86, and x86_64 in the RuntimeIdentifiers and configures the project to bundle all supported ABIs into a single universal APK. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Packaging all ABIs into a single APK can significantly increase the download size; consider using split APKs or an Android App Bundle (AAB) to optimize delivery per architecture.
- Verify that the AndroidSupportedAbis setting actually produces a .apk containing native libraries for armeabi-v7a, arm64-v8a, x86, and x86_64 under lib/ directories to avoid missing native libs at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Packaging all ABIs into a single APK can significantly increase the download size; consider using split APKs or an Android App Bundle (AAB) to optimize delivery per architecture.
- Verify that the AndroidSupportedAbis setting actually produces a .apk containing native libraries for armeabi-v7a, arm64-v8a, x86, and x86_64 under lib/ directories to avoid missing native libs at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
dotnet build osu.Desktop/osu.Desktop.csproj -c Release(fails:dotnetis not available in the execution environment)https://chatgpt.com/codex/tasks/task_e_68c9f5d229748331947c77078692107d
Summary by Sourcery
Expand Android ABI support and produce a universal APK for all architectures
Enhancements: