Add gRPC Support, Fix PreAuth Key/Routes API, and Enable Display Name for User Creation#82
Add gRPC Support, Fix PreAuth Key/Routes API, and Enable Display Name for User Creation#82OwnDing wants to merge 10 commits intoGoodiesHQ:mainfrom
Conversation
…e components, including user creation, gRPC connection diagnostics, and settings. Update error messages and success notifications for clarity and consistency. Enhance comments in the code for better understanding and maintainability.
awalon
left a comment
There was a problem hiding this comment.
Hello OwnDing,
may I ask you why are you using 'vpn.ownding.xyz'? This could cause at least a bad feeling seeing third party URLs and could cause a security risk for you and other users where C'n'P is used.
For documentation and as fallback something generic like 'example.com' further Information or 'enter your domain here' should be used whenever configured headscale instance cannot be used (ex. Documentation) and no fallback to somewhere else (there could be an error for missing value instead).
Thanks & Greets, Awalon
|
Hi Awalon, @awalon Best regards, |
….com' in response analysis and gRPC help components
…m' for connection testing
|
Any updates on this? |
Pull Request Description:
This PR introduces several improvements and bug fixes to enhance the functionality and usability of
headscale-admin. Below is a summary of the changes:✅ Key Additions & Fixes
gRPC Integration
headscalebackend. This improves performance and simplifies interactions with gRPC-based APIs.API Endpoint Fixes
/api/v1/preauthkey: Resolved issues with pre-auth key creation and retrieval, ensuring seamless integration withheadscale./api/v1/routes: Corrected route management functionality, enabling proper enable/disable operations for advertised routes.Enhanced User Management
displayNameSupport: Users can now create users with an optionaldisplayNamefield, improving user identification and organization in larger deployments.🧪 Testing & Validation
All changes have been tested locally and verified against the latest
headscalev0.26.1 backend. The gRPC integration has been validated for compatibility with both existing and new API endpoints.📝 Notes for Reviewers
displayNamefeature is backward-compatible and does not affect existing user data.This PR aligns with the project’s goal of providing a modern, stateless web interface for
headscalewhile addressing critical bugs and expanding functionality. Let me know if further adjustments or clarifications are needed!