Fix function type error in README#20
Fix function type error in README#20ahuglajbclajep wants to merge 2 commits intoGoogleChromeLabs:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@developit I’d love your feedback, please review my PR. |
|
Maybe in the So the config looks like: module.exports = {
module: {
rules: [
{
test: /\.worker\.(js|ts)$/i,
use: [{
loader: 'comlink-loader',
options: {
singleton: true
}
},
"ts-loader"]
}
]
}
}Otherwise there will / may be build-failures like |
|
@gfoidl The README is correct in this regard, as it works if you write the module.exports = {
module: {
rules: [
{
test: /\.worker\.[tj]s$/,
loader: "comlink-loader?singleton",
},
{
test: /\.[tj]sx?$/,
loader: "ts-loader",
exclude: /node_modules/,
}
]
}
} |
|
Ahhh, that's good to know. Thank you very much! 👍 😃 |
Fix type error of
greetfunction in README.See also #1.
Also, TypeScript does not allow the addition of
".ts"when importing*.ts.https://www.typescriptlang.org/docs/handbook/modules.html#import
I also fix the README small mistake about this behavior.