Skip to content

Merge V1.74.0 into Develop#4936

Merged
Neelabh94 merged 3 commits intodevelopfrom
main
Dec 4, 2025
Merged

Merge V1.74.0 into Develop#4936
Neelabh94 merged 3 commits intodevelopfrom
main

Conversation

@aslam-quad
Copy link
Contributor

@aslam-quad aslam-quad commented Dec 4, 2025

Merge V1.74.0 into Develop

@aslam-quad aslam-quad requested review from a team and samskillman as code owners December 4, 2025 10:21
@aslam-quad aslam-quad added the release-chore To not include into release notes label Dec 4, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aslam-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine version bump for the HPC Toolkit, updating the core application version and aligning all associated Terraform modules to v1.74.0. This ensures consistency across the toolkit's components and prepares the develop branch for the next iteration or integrates changes from a recent release.

Highlights

  • Application Version Update: The main application's version string in cmd/root.go has been updated from v1.73.1 to v1.74.0, reflecting the new release version.
  • Terraform Module Version Alignment: All versions.tf files across various community and core Terraform modules have been updated to consistently reference v1.74.0 in their module_name metadata, ensuring all components are aligned with the new version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily consists of version bumps from v1.73.1 to v1.74.0 across numerous module files, which is typical for a release merge. The changes are mostly consistent, but I've identified a couple of minor inconsistencies in the versioning of google-beta providers in two modules. My feedback points these out to ensure consistency across the codebase.

}
provider_meta "google" {
module_name = "blueprints/terraform/hpc-toolkit:gke-node-pool/v1.73.1"
module_name = "blueprints/terraform/hpc-toolkit:gke-node-pool/v1.74.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The module_name version for the google provider has been updated, but the version for the google-beta provider on line 36 remains v1.45.0. This appears inconsistent with other modules in this pull request where both provider versions were updated. Please update the google-beta provider's version to v1.74.0 for consistency, unless this was intentional.

References
  1. The repository style guide emphasizes maintaining quality and consistency. The inconsistent versioning between google and google-beta providers could affect maintainability and consistency. (link)

}
provider_meta "google" {
module_name = "blueprints/terraform/hpc-toolkit:gke-cluster/v1.73.1"
module_name = "blueprints/terraform/hpc-toolkit:gke-cluster/v1.74.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The module_name version for the google provider has been updated, but the version for the google-beta provider on line 37 remains v1.45.0. For consistency with other modules, this should likely be updated to v1.74.0 as well.

References
  1. The repository style guide emphasizes maintaining quality and consistency. The inconsistent versioning between google and google-beta providers could affect maintainability and consistency. (link)

@cboneti cboneti changed the base branch from develop to merge-rc-to-dev December 4, 2025 10:32
@cboneti cboneti changed the base branch from merge-rc-to-dev to develop December 4, 2025 10:32
@Neelabh94 Neelabh94 merged commit 057decf into develop Dec 4, 2025
21 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants