Migrate configure_kueue from gavinbunney to helm#5129
Merged
agrawalkhushi18 merged 8 commits intoGoogleCloudPlatform:developfrom Feb 16, 2026
Merged
Migrate configure_kueue from gavinbunney to helm#5129agrawalkhushi18 merged 8 commits intoGoogleCloudPlatform:developfrom
agrawalkhushi18 merged 8 commits intoGoogleCloudPlatform:developfrom
Conversation
agrawalkhushi18
added
release-module-improvements
agrawalkhushi18
force-pushed
the
migration-k8s
branch
from
9b86340 to
b63be46
Compare
shubpal07
reviewed
Jan 27, 2026
shubpal07
reviewed
Jan 27, 2026
shubpal07
reviewed
Jan 27, 2026
shubpal07
reviewed
Jan 27, 2026
shubpal07
reviewed
Jan 27, 2026
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_gcluster_failure.yml
Outdated
Show resolved
Hide resolved
shubpal07
requested changes
Jan 27, 2026
Contributor
shubpal07
left a comment
shubpal07
left a comment
There was a problem hiding this comment.
great work. Added few thoughts
…for better code readability
agrawalkhushi18
force-pushed
the
migration-k8s
branch
from
2680f39 to
5e76d67
Compare
swarnabm
reviewed
Feb 13, 2026
swarnabm
approved these changes
Feb 13, 2026
shubpal07
reviewed
Feb 13, 2026
shubpal07
reviewed
Feb 13, 2026
shubpal07
reviewed
Feb 13, 2026
shubpal07
approved these changes
Feb 13, 2026
Contributor
shubpal07
left a comment
shubpal07
left a comment
There was a problem hiding this comment.
LGTM! The migration to helm_install and the generic custom helm chart is a great architectural improvement. It significantly cleans up the lifecycle management compared to the previous kubectl provider approach.
I have a few non-blocking suggestions below to harden the manifest splitting logic against edge cases and to verify the removal of server_side_apply. We may consider taking this into the next iteration.
agrawalkhushi18
merged commit 1a457ab
into
GoogleCloudPlatform:develop
43 of 96 checks passed
kadupoornima
pushed a commit
to kadupoornima/cluster-toolkit
that referenced
this pull request
Feb 17, 2026
…#5129) I will be taking up few non-blocking suggestions in a follow up PR. Thanks!
AdarshK15
pushed a commit
to AdarshK15/cluster-toolkit
that referenced
this pull request
Feb 18, 2026
…#5129) I will be taking up few non-blocking suggestions in a follow up PR. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the
configure_kueuemodule from the communitygavinbunney/kubectlprovider to the officialhashicorp/helm provider. This is part of the work to remove the third‑party kubectl-apply dependency and standardize on the official Helm provider for chart-based installs and upgrades.The module now deploys the Kueue chart via helm_release (helm provider) instead of applying raw manifests through the kubectl provider.
The changes have been tested in local and the builds were successful.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.