Skip to content

Fix: Inactivity pr action workflow#5178

Open
Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94:inactivity-pr
Open

Fix: Inactivity pr action workflow#5178
Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94:inactivity-pr

Conversation

@Neelabh94
Copy link
Contributor

@Neelabh94 Neelabh94 commented Feb 3, 2026

This PR adds retry logic to the inactivity PR workflow's list command. Also, fixes some syntactical and logical bug.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@Neelabh94 Neelabh94 changed the base branch from main to develop February 3, 2026 13:16
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the robustness of the inactivity PR workflow by adding a retry mechanism to the GitHub API call that fetches pull requests. It also includes a fix for a syntax error in a jq command. The changes are logical and well-implemented. I have one suggestion to improve maintainability by replacing magic numbers with named constants in the new retry logic.

@Neelabh94 Neelabh94 added the release-chore To not include into release notes label Feb 3, 2026
@Neelabh94
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces valuable enhancements by adding retry logic to the PR fetching command and refining the inactivity calculation to focus on human activity. The changes are a good step towards making the workflow more robust. However, I've identified a critical bug that could cause the script to attempt actions on already closed pull requests, a bug in the new retry logic's exit condition, and a logical flaw in the inactivity calculation that could reduce its accuracy. I've provided specific suggestions to address these issues and improve the overall implementation.

@Neelabh94 Neelabh94 force-pushed the inactivity-pr branch 6 times, most recently from 0ff4116 to 9c10037 Compare February 4, 2026 12:47
@Neelabh94 Neelabh94 marked this pull request as ready for review February 4, 2026 13:14
@Neelabh94 Neelabh94 requested review from a team and samskillman as code owners February 4, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant