Fix: Inactivity pr action workflow#5178
Fix: Inactivity pr action workflow#5178Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the inactivity PR workflow by adding a retry mechanism to the GitHub API call that fetches pull requests. It also includes a fix for a syntax error in a jq command. The changes are logical and well-implemented. I have one suggestion to improve maintainability by replacing magic numbers with named constants in the new retry logic.
acd3ef4 to
5e4ded7
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces valuable enhancements by adding retry logic to the PR fetching command and refining the inactivity calculation to focus on human activity. The changes are a good step towards making the workflow more robust. However, I've identified a critical bug that could cause the script to attempt actions on already closed pull requests, a bug in the new retry logic's exit condition, and a logical flaw in the inactivity calculation that could reduce its accuracy. I've provided specific suggestions to address these issues and improve the overall implementation.
0ff4116 to
9c10037
Compare
9c10037 to
d71bc8d
Compare
d71bc8d to
97fcdbc
Compare
This PR adds retry logic to the inactivity PR workflow's list command. Also, fixes some syntactical and logical bug.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.