Remove a3u gcs blueprint

[AdarshK15]

Remove deprecated a3u-gcs blueprint and its references, moved the tests to latest a3ultra folder.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello @AdarshK15, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on repository cleanup by eliminating a deprecated A3U GCS blueprint. This action streamlines the codebase by removing outdated components and ensures that relevant test assets are preserved and correctly located within the active A3 Ultra blueprint directory, maintaining the integrity of the project's validation processes.

Highlights

• Blueprint Removal: The deprecated a3u-gcs blueprint and its associated configuration files have been completely removed from the repository.
• Test Relocation: System benchmark scripts previously located within the deprecated blueprint's directory have been moved to the a3-ultragpu-8g folder to ensure their continued use and relevance.
• Validation Script Update: The validate_configs.sh script was updated to remove the exclusion path for the now-deleted a3u-gcs blueprint.

Changelog

• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/README.md
  • Removed the README file for the deprecated blueprint.
• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/a3u-slurm-ubuntu-gcs.yaml
  • Removed the main blueprint configuration file.
• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/deployment.yaml
  • Removed the deployment configuration file.
• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/system_benchmarks/README.md
  • Renamed the benchmark README to the new A3 Ultra folder.
• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/system_benchmarks/run-hpl-via-ramble.sh
  • Renamed the HPL benchmark script to the new A3 Ultra folder.
• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/system_benchmarks/run-nccl-tests-via-ramble.sh
  • Renamed the NCCL benchmark script to the new A3 Ultra folder.
• examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/system_benchmarks/run-nemo-via-ramble.sh
  • Renamed the NeMo benchmark script to the new A3 Ultra folder.
• tools/validate_configs/validate_configs.sh
  • Updated the configuration validation script to remove the exclusion for the deprecated blueprint path.

Activity

• The pull request has been submitted and is awaiting review.
• The author has completed the submission checklist, including testing changes locally, ensuring unit test coverage, and updating documentation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the deprecated a3u-gcs blueprint and moves its associated tests to the a3-ultragpu-8g example, which aligns with the stated goal. However, the changes in tools/validate_configs/validate_configs.sh include modifications that seem unrelated to the removal of the a3u-gcs blueprint, such as removing a4x-maxgpu-4g-metal from the exclusion list and updating gke-tpu-v6e paths to gke-tpu-v6. According to the repository style guide (line 43), the PR description should clearly explain all changes. Please consider updating the description to include these additional cleanups or moving them to a separate pull request to maintain clarity. The comment regarding the readability of the validation script has been retained.

[gemini-code-assist]

This line is very long and hard to read, which impacts maintainability. To improve readability, consider breaking the find command into multiple lines, with one -not -path per line.

CONFIGS=$(find examples/ community/examples/ tools/validate_configs/test_configs/ docs/tutorials/ docs/videos/build-your-own-blueprint/ -name "*.yaml" -type f \
    -not -path 'examples/machine-learning/a3-megagpu-8g/*' \
    -not -path 'examples/machine-learning/a3-ultragpu-8g/*' \
    -not -path 'examples/machine-learning/build-service-images/*' \
    -not -path 'examples/gke-a3-ultragpu/*' \
    -not -path 'examples/gke-consumption-options/*' \
    -not -path 'examples/gke-a4/*' \
    -not -path 'examples/gke-a3-megagpu/*' \
    -not -path 'examples/machine-learning/a4-highgpu-8g/*' \
    -not -path 'examples/machine-learning/a4x-highgpu-4g/*' \
    -not -path 'community/examples/gke-tpu-v6/*' \
    -not -path 'community/examples/xpk-n2-filestore/*' \
    -not -path 'examples/gke-a4x/*' \
    -not -path 'examples/science/af3-slurm/*' \
    -not -path 'examples/gke-h4d/*' \
    -not -path 'community/examples/hpc-slinky/*' \
    -not -path 'examples/gke-g4/*' \
    -not -path 'community/examples/slurm-gke/*' \
    -not -path 'examples/hpc-slurm-h4d/*' \
    -not -path 'examples/machine-learning/a3-highgpu-8g/*' \
    -not -path 'examples/netapp-volumes.yaml' \
    -not -path 'examples/gke-tpu-7x/*' \
    -not -path 'examples/gke-tpu-v6/*')

References

1. Code should be easy to understand, modify, and extend. The long, single-line find command is difficult to read and maintain. ^(link)