Skip to content

Update terraform-provider version to >= 6.9.0, <= 7.18.0#5243

Draft
sudheer-quad wants to merge 1 commit intoGoogleCloudPlatform:developfrom
sudheer-quad:update-terraform-provider
Draft

Update terraform-provider version to >= 6.9.0, <= 7.18.0#5243
sudheer-quad wants to merge 1 commit intoGoogleCloudPlatform:developfrom
sudheer-quad:update-terraform-provider

Conversation

@sudheer-quad
Copy link
Contributor

This PR updates terraform-provider version to >= 6.9.0, <= 7.18.0

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Feb 13, 2026
@github-actions github-actions bot added the external PR from external contributor label Feb 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sudheer-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the supported version range for the Google and Google-beta Terraform providers. By allowing version 7.18.0, the change ensures compatibility with the latest provider releases, enabling users to leverage new features, improvements, and bug fixes without encountering version constraint issues.

Highlights

  • Terraform Provider Version Update: The maximum allowed version for the hashicorp/google and hashicorp/google-beta Terraform providers has been updated from <= 7.17.0 to <= 7.18.0.
  • Configuration and Test File Updates: This version range adjustment has been applied across the Go codebase, test files, and various golden copy configuration files (.yaml and .tf) to reflect the new supported provider version.
Changelog
  • pkg/config/expand.go
    • Updated the default version constraint for google and google-beta Terraform providers to include <= 7.18.0.
  • pkg/config/expand_test.go
    • Adjusted the expected version constraint for google and google-beta Terraform providers in the TestExpandProviders test case to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/igc_pkr/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated the version field for google and google-beta Terraform providers in the expanded blueprint golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/igc_pkr/zero/versions.tf
    • Modified the version constraint for google and google-beta providers in the versions.tf golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/igc_tf/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated the version field for google and google-beta Terraform providers in the expanded blueprint golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/igc_tf/one/versions.tf
    • Modified the version constraint for google and google-beta providers in the versions.tf golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/igc_tf/zero/versions.tf
    • Modified the version constraint for google and google-beta providers in the versions.tf golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/merge_flatten/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated the version field for google and google-beta Terraform providers in the expanded blueprint golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/merge_flatten/zero/versions.tf
    • Modified the version constraint for google and google-beta providers in the versions.tf golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/versioned_blueprint/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated the version field for google and google-beta Terraform providers in the expanded blueprint golden copy to <= 7.18.0.
  • tools/validate_configs/golden_copies/expectations/versioned_blueprint/primary/versions.tf
    • Modified the version constraint for google and google-beta providers in the versions.tf golden copy to <= 7.18.0.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the version constraint for the Google Terraform providers across the codebase. The changes are consistent and include updates to the Go source, tests, and golden test files.

I've added a couple of suggestions to improve maintainability by using constants for the repeated version strings. This is a minor improvement but good practice for keeping the code clean. Overall, the PR is in good shape.

"google": {
Source: "hashicorp/google",
Version: ">= 6.9.0, <= 7.17.0",
Version: ">= 6.9.0, <= 7.18.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This version string is duplicated for the google-beta provider on line 206. To improve maintainability and avoid repeating this 'magic string', consider defining it as a constant and reusing it in both places. This would make future version updates simpler and less prone to error.

"google": TerraformProvider{
Source: "hashicorp/google",
Version: ">= 6.9.0, <= 7.17.0"},
Version: ">= 6.9.0, <= 7.18.0"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the main source file, this version string is duplicated for the google-beta provider on line 99. For better maintainability and consistency, it would be good to define this as a constant within the test as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant