Skip to content

Add Prefix For PR Tests#5245

Merged
LAVEEN merged 2 commits intoGoogleCloudPlatform:developfrom
LAVEEN:prprefix
Feb 16, 2026
Merged

Add Prefix For PR Tests#5245
LAVEEN merged 2 commits intoGoogleCloudPlatform:developfrom
LAVEEN:prprefix

Conversation

@LAVEEN
Copy link
Contributor

@LAVEEN LAVEEN commented Feb 16, 2026

Add a prefix for PR Tests

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN requested review from a team and samskillman as code owners February 16, 2026 14:32
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LAVEEN, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a standardized prefix for resources provisioned by pull request tests within the Cloud Build environment. By adding a _TEST_PREFIX substitution to the Cloud Build trigger, it ensures that all subsequent test-related resources will be clearly identifiable, improving resource management and preventing naming conflicts.

Highlights

  • Cloud Build Configuration: Added a _TEST_PREFIX substitution with the value "pr-" to the pr_test Cloud Build trigger, ensuring that resources created by pull request tests are consistently prefixed.
Changelog
  • tools/cloud-build/provision/pr-tests.tf
    • Added a _TEST_PREFIX substitution to the pr_test Cloud Build trigger.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@saara-tyagi27 saara-tyagi27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls put appropriate pr label

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a _TEST_PREFIX substitution to the Cloud Build triggers for pull request tests. This is a useful change for differentiating resources created during PR testing. However, the pull request description should be filled out to explain the purpose of the change and how it was tested, as required by the repository's style guide. Additionally, there's an opportunity to improve maintainability by defining the new prefix as a local variable, as suggested in the code review comment.

@LAVEEN LAVEEN added the release-chore To not include into release notes label Feb 16, 2026
@LAVEEN LAVEEN enabled auto-merge (squash) February 16, 2026 14:36
@LAVEEN LAVEEN merged commit 9a9c97f into GoogleCloudPlatform:develop Feb 16, 2026
14 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants