Open
Conversation
This test verifies that the output from this system is usable by the `go get` tool. It operates by proxying `go get` HTTP requests to a locally running proxy, then checking the URL the VCS cloned from. This isn't a hermetic test: it requires internet access to github.com and bitbucket.org, which I'm not sure how to reasonably fake and provide the same level of confidence. It checks PATH for locally installed copies of go, git, and hg, but those could be bundled in a test environment. I bumped up the version of Go required/tested against to Go 1.8 in order to use subtests. Go 1.8 is now GA on App Engine, so this should not be a problem.
zombiezen
force-pushed
the
integration
branch
from
5a23d66 to
0a85688
Compare
Contributor
Author
|
@rakyll ping |
Contributor
|
I didn't truly understand why we need to verify go get requests. Don't we instead need to test manually cloning and go get'in from the vanity URL and assert whether the downloaded repo is the same? |
Contributor
Author
|
The reason I'm not checking the contents of the checkout right now is because the repository could change while the test is running, since the test is not hermetic. I agree that it would be good to check the commit, especially since I'm building toward the feature I described in #17 and want to build confidence that it works. Perhaps I should bite the bullet and have the test spin up a local Git HTTP server? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test verifies that the output from this system is usable by the
go gettool. It operates by proxyinggo getHTTP requests to a locallyrunning proxy, then checking the URL the VCS cloned from.
This isn't a hermetic test: it requires internet access to github.com
and bitbucket.org, which I'm not sure how to reasonably fake and provide
the same level of confidence. It checks PATH for locally installed
copies of go, git, and hg, but those could be bundled in a test
environment.
I bumped up the version of Go required/tested against to Go 1.8 in order
to use subtests. Go 1.8 is now GA on App Engine, so this should not be
a problem.