Adds build system and project to pyproject.toml file#1382
Adds build system and project to pyproject.toml file#1382douglasjacobsen merged 3 commits intoGoogleCloudPlatform:developfrom
Conversation
Summary of ChangesHello @sarthakag, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Python packaging and build configuration by implementing a "pyproject.toml" file. This change streamlines the project setup process, allowing for standard installation via "pip install .", and centralizes essential project metadata, enhancing compatibility with contemporary Python tooling and improving overall project maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modernizes the project's packaging by adding a pyproject.toml with build system and project metadata. This is a valuable change. My review provides a consolidated set of suggestions to refine this configuration, focusing on enabling dynamic versioning with setuptools-scm, aligning the required Python version with the project's actual support, and enriching the package classifiers for better discoverability. These changes will help create a more robust and professional package.
137c287 to
d0a471a
Compare
59987bc to
a8f9d5f
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the project's packaging to use pyproject.toml with setuptools, which is a great step towards modernizing the build system. The configuration correctly sets up the project metadata, dependencies, and data files. However, I've found a few critical issues in the packaging configuration that will likely cause the build to fail or produce an incorrect package. Specifically, the setuptools-scm configuration is incomplete, the package discovery is misconfigured to include non-package directories, and there's a redundant package-data section. Please see my detailed comments for suggestions on how to fix these issues.
|
Hi @linsword13, The PR is ready for review, PTAL and run the CICD if required. Thank you! |
|
/gcbrun |
|
/gcbrun |
532c5dc
into
GoogleCloudPlatform:develop
Command
pip3 install .sets up the project environment with the dependencies.