Skip to content

Adds build system and project to pyproject.toml file#1382

Merged
douglasjacobsen merged 3 commits intoGoogleCloudPlatform:developfrom
sarthakag:req
Feb 17, 2026
Merged

Adds build system and project to pyproject.toml file#1382
douglasjacobsen merged 3 commits intoGoogleCloudPlatform:developfrom
sarthakag:req

Conversation

@sarthakag
Copy link
Contributor

Command pip3 install . sets up the project environment with the dependencies.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sarthakag, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's Python packaging and build configuration by implementing a "pyproject.toml" file. This change streamlines the project setup process, allowing for standard installation via "pip install .", and centralizes essential project metadata, enhancing compatibility with contemporary Python tooling and improving overall project maintainability.

Highlights

  • Build System Configuration: Introduced a "[build-system]" section in "pyproject.toml" to define build requirements (setuptools, wheel) and specify "setuptools.build_meta" as the build backend.
  • Project Metadata Definition: Added a "[project]" section to "pyproject.toml", centralizing project metadata such as name ("ramble"), version ("0.6.0"), description, readme, Python compatibility (>=3.7), and licenses (Apache-2.0 OR MIT).
  • Dynamic Dependency Management: Configured dynamic dependencies within the "[tool.setuptools.dynamic]" section to automatically read project dependencies from "requirements.txt".
  • Package Discovery: Set up package discovery under "[tool.setuptools.packages.find]" to include packages matching "ramble*" located in the "lib" directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modernizes the project's packaging by adding a pyproject.toml with build system and project metadata. This is a valuable change. My review provides a consolidated set of suggestions to refine this configuration, focusing on enabling dynamic versioning with setuptools-scm, aligning the required Python version with the project's actual support, and enriching the package classifiers for better discoverability. These changes will help create a more robust and professional package.

@sarthakag sarthakag force-pushed the req branch 25 times, most recently from 137c287 to d0a471a Compare January 27, 2026 14:08
@sarthakag sarthakag force-pushed the req branch 2 times, most recently from 59987bc to a8f9d5f Compare January 28, 2026 08:40
@sarthakag
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's packaging to use pyproject.toml with setuptools, which is a great step towards modernizing the build system. The configuration correctly sets up the project metadata, dependencies, and data files. However, I've found a few critical issues in the packaging configuration that will likely cause the build to fail or produce an incorrect package. Specifically, the setuptools-scm configuration is incomplete, the package discovery is misconfigured to include non-package directories, and there's a redundant package-data section. Please see my detailed comments for suggestions on how to fix these issues.

@sarthakag sarthakag marked this pull request as ready for review January 28, 2026 10:42
@sarthakag
Copy link
Contributor Author

Hi @linsword13,

The PR is ready for review, PTAL and run the CICD if required. Thank you!

@douglasjacobsen
Copy link
Collaborator

/gcbrun

@douglasjacobsen
Copy link
Collaborator

/gcbrun

@douglasjacobsen douglasjacobsen merged commit 532c5dc into GoogleCloudPlatform:develop Feb 17, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants