Add bazel platform support#469
Merged
thesayyn merged 2 commits intoGoogleContainerTools:mainfrom Jan 24, 2025
Merged
Conversation
|
Is someone able to review this? @loosebazooka Are you a maintainer? Please can you take a look at this? |
thesayyn
approved these changes
Jan 20, 2025
|
@Sineaggi Looks like this can be merged now? |
Contributor
Author
|
@njlr Somebody with write access would have to merge it. |
Collaborator
|
Can you force push to kick CI? I can't merge without them being run. |
Sineaggi
force-pushed
the
add-bazel-platform-support
branch
from
30055bc to
071f68e
Compare
Contributor
Author
|
@thesayyn done |
Sineaggi
force-pushed
the
add-bazel-platform-support
branch
from
071f68e to
cf92541
Compare
Contributor
Author
|
@thesayyn I merged in main, perhaps being behind caused the build failure. |
Collaborator
|
Lets see the CI, i'll merge anyway if its unrelated failure. |
TvdW
added a commit
to TvdW/container-structure-test
that referenced
this pull request
Jan 21, 2026
PR GoogleContainerTools#469 added this and added a default, which breaks container_structure_test on ARM. Let's remove the default so that we can choose whether we want to set a platform, restoring original behavior.
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bazel platform support.