Sourcery refactored master branch #1

sourcery-ai · 2023-12-04T15:31:34Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Sourcery timed out performing refactorings.

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2023-12-04T15:31:36Z

build_scripts/build_usd.py

-    try:
+    with contextlib.suppress(subprocess.CalledProcessError):
        return subprocess.check_output("xcode-select -p").strip()
-    except subprocess.CalledProcessError:
-        pass


Function GetXcodeDeveloperDirectory refactored with the following changes:

Use contextlib's suppress method to silence an error (use-contextlib-suppress)

sourcery-ai · 2023-12-04T15:31:36Z

build_scripts/build_usd.py

-    msvcCompiler = find_executable('cl')
-    if msvcCompiler:
-        match = re.search(
-            "Compiler Version (\d+).(\d+).(\d+)", 
-            subprocess.check_output("cl", stderr=subprocess.STDOUT))
-        if match:
+    if msvcCompiler := find_executable('cl'):
+        if match := re.search(
+            "Compiler Version (\d+).(\d+).(\d+)",
+            subprocess.check_output("cl", stderr=subprocess.STDOUT),
+        ):


Function GetVisualStudioCompilerAndVersion refactored with the following changes:

Use named expression to simplify assignment and conditional [×2] (use-named-expression)

sourcery-ai · 2023-12-04T15:31:37Z

build_scripts/build_usd.py

-        msvcCompilerAndVersion = GetVisualStudioCompilerAndVersion()
-        if msvcCompilerAndVersion:
+        if msvcCompilerAndVersion := GetVisualStudioCompilerAndVersion():


Function RunCMake refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Move setting of default value for variable into else branch (introduce-default-else)

Replace if statement with if expression (assign-if-exp)

This removes the following comments ( why? ):

# On MacOS, enable the use of @rpath for relocatable builds.

sourcery-ai · 2023-12-04T15:31:37Z

build_scripts/build_usd.py

-        PrintInfo("Patching file {filename} (original in {oldFilename})..."
-                  .format(filename=filename, oldFilename=filename + ".old"))
-        shutil.copy(filename, filename + ".old")
+        PrintInfo(
+            "Patching file {filename} (original in {oldFilename})...".format(
+                filename=filename, oldFilename=f"{filename}.old"
+            )
+        )
+        shutil.copy(filename, f"{filename}.old")


Function PatchFile refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:37Z

build_scripts/build_usd.py

-        filename = url.split("/")[-1]       
+        filename = url.split("/")[-1]


Function DownloadURL refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:38Z

cmake/macros/testWrapper.py

-    if retcode < 0:
-        return 128 + abs(retcode)
-    return retcode
+    return 128 + abs(retcode) if retcode < 0 else retcode


Function _convertRetCode refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-12-04T15:31:38Z

extras/usd/examples/usdMakeFileVariantModelAsset/usdMakeFileVariantModelAsset.py

-    
+
    if not args.assetName or args.assetName == '':
        parser.error("No assetName specified")
-    
-    stage = CreateModelStage(args.assetName,
-                             assetIdentifier=args.identifier,
-                             kind=args.kind,
-                             filesToReference=args.variantFiles,
-                             variantSetName=args.variantSet,
-                             defaultVariantSelection=args.defaultVariantSelection)
-
-    if stage:
+
+    if stage := CreateModelStage(
+        args.assetName,
+        assetIdentifier=args.identifier,
+        kind=args.kind,
+        filesToReference=args.variantFiles,
+        variantSetName=args.variantSet,
+        defaultVariantSelection=args.defaultVariantSelection,
+    ):


Lines 162-173 refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

sourcery-ai · 2023-12-04T15:31:38Z

extras/usd/examples/usdviewPlugins/sendMail.py

-        else:
-            imagedata = viewportShot
-
+        imagedata = windowShot if mailInfo.imagetype == "Window" else viewportShot


Function SendMail refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-12-04T15:31:38Z

extras/usd/examples/usdviewPlugins/sendMail.py

-    body = str("Usdview screenshot, taken " + currtime + "\n" +
-               "----------------------------------------" + "\n" +
-               "File: "
-                  + str(usdviewApi.stageIdentifier) + "\n" +
-               "Selected Prim Paths: "
-                  + ", ".join(map(str, usdviewApi.selectedPrims)) + "\n" +
-               "Current Frame: "
-                  + str(usdviewApi.frame) + "\n" +
-               "Complexity: "
-                  + str(usdviewApi.dataModel.viewSettings.complexity) + "\n" +
-               "Camera Info:\n" +str(camera) + "\n" +
-               "----------------------------------------" + "\n")
+    body = str(
+        (
+            (
+                (
+                    (
+                        (
+                            (
+                                (
+                                    (
+                                        (
+                                            (
+                                                (
+                                                    (
+                                                        (
+                                                            (
+                                                                f"Usdview screenshot, taken {currtime}"
+                                                                + "\n"
+                                                                + "----------------------------------------"
+                                                            )
+                                                            + "\n"
+                                                        )
+                                                        + "File: "
+                                                    )
+                                                    + str(
+                                                        usdviewApi.stageIdentifier
+                                                    )
+                                                    + "\n"
+                                                )
+                                                + "Selected Prim Paths: "
+                                            )
+                                            + ", ".join(
+                                                map(
+                                                    str,
+                                                    usdviewApi.selectedPrims,
+                                                )
+                                            )
+                                            + "\n"
+                                        )
+                                        + "Current Frame: "
+                                    )
+                                    + str(usdviewApi.frame)
+                                    + "\n"
+                                )
+                                + "Complexity: "
+                            )
+                            + str(usdviewApi.dataModel.viewSettings.complexity)
+                            + "\n"
+                        )
+                        + "Camera Info:\n"
+                    )
+                    + str(camera)
+                    + "\n"
+                )
+                + "----------------------------------------"
+            )
+            + "\n"
+        )
+    )


Function _GenerateDefaultInfo refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:39Z

extras/usd/tutorials/endToEnd/scripts/create_asset.py

    if os.path.exists(outputDir):
        if not force:
-            parser.error('outputDir "%s" exists.  Use -f to override' % outputDir)
+            parser.error(f'outputDir "{outputDir}" exists.  Use -f to override')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-12-04T15:31:42Z

extras/usd/tutorials/endToEnd/scripts/create_shot.py

    if os.path.exists(outputDir):
        if not force:
-            parser.error('outputDir "%s" exists.  Use -f to override' % outputDir)
+            parser.error(f'outputDir "{outputDir}" exists.  Use -f to override')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-12-04T15:31:42Z

extras/usd/tutorials/endToEnd/tutorial_scripts/add_shadingVariants.py

        with shadingVariant.GetVariantEditContext():
            whichBall = variantName.split('_')[-1]
-            texPath = os.path.join(texDir, 'ball%s.tex' % whichBall)
+            texPath = os.path.join(texDir, f'ball{whichBall}.tex')


Function _AddShadingToBall refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-12-04T15:31:42Z

extras/usd/tutorials/endToEnd/tutorial_scripts/layout_shot_s00_01.py

    # want to deactivate so that we don't delete while iterating.
    roomProps = stage.GetPrimAtPath('/World/sets/Room_set/Props')
-    keepers = set(['Ball_%d' % i for i in [1, 9, 8, 4] ])
+    keepers = {'Ball_%d' % i for i in [1, 9, 8, 4]}


Function _SetupBilliards refactored with the following changes:

Replace list(), dict() or set() with comprehension (collection-builtin-to-comprehension)

Replace unneeded comprehension with generator (comprehension-to-generator)

sourcery-ai · 2023-12-04T15:31:42Z

extras/usd/tutorials/traversingStage/traversingStage.py

-assert([x for x in stage.Traverse()] == [stage.GetPrimAtPath("/refSphere"), 
-    stage.GetPrimAtPath("/refSphere/world"), stage.GetPrimAtPath("/refSphere2"), 
-    stage.GetPrimAtPath("/refSphere2/world")])
+assert list(stage.Traverse()) == [
+    stage.GetPrimAtPath("/refSphere"),
+    stage.GetPrimAtPath("/refSphere/world"),
+    stage.GetPrimAtPath("/refSphere2"),
+    stage.GetPrimAtPath("/refSphere2/world"),
+]


Lines 30-63 refactored with the following changes:

Replace identity comprehension with call to collection constructor [×2] (identity-comprehension)

sourcery-ai · 2023-12-04T15:31:42Z

pxr/base/lib/gf/gfGenCode.py

-        return 'h'
-    else:
-        return scl[0]
+    return 'h' if scl == 'GfHalf' else scl[0]


Function ScalarSuffix refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-12-04T15:31:44Z

pxr/base/lib/gf/testenv/testGfMath.py


 def err( msg ):
-    return "ERROR: " + msg + " failed"
+    return f"ERROR: {msg} failed"


Function err refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:44Z

pxr/base/lib/gf/testenv/testGfMatrix.py

-    else:
-        v = Value()
-        for i in range(v.dimension):
-            v[i] = vals[i]
+    v = Value()
+    for i in range(v.dimension):
+        v[i] = vals[i]


Function makeValue refactored with the following changes:

Remove unnecessary else after guard condition (remove-unnecessary-else)

sourcery-ai · 2023-12-04T15:31:44Z

pxr/base/lib/gf/testenv/testGfMatrix.py

-            m[0,0] = 1; m[1,0] = 2; m[0,1] = 3; m[1,1] = 4
+            m[0,0] = 1
+            m[1,0] = 2
+            m[0,1] = 3
+            m[1,1] = 4
            self.assertTrue(m[0,0] == 1 and m[1,0] == 2 and m[0,1] == 3 and m[1,1] == 4)
-            
+
            m = Matrix()
-            m[-1,-1] = 1; m[-2,-1] = 2; m[-1,-2] = 3; m[-2,-2] = 4
+            m[-1,-1] = 1
+            m[-2,-1] = 2
+            m[-1,-2] = 3
+            m[-2,-2] = 4
            self.assertTrue(m[-1,-1] == 1 and m[-2,-1] == 2 and m[-1,-2] == 3 and m[-2,-2] == 4)
-            
+


Function TestGfMatrix.test_Other refactored with the following changes:

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2023-12-04T15:31:44Z

pxr/base/lib/gf/testenv/testGfMatrix.py

-            AssertDeterminant(m1 * m1, det1 * det1)
+            AssertDeterminant(m1 * m1, det1**2)


Function TestGfMatrix.test_Matrix4Determinant refactored with the following changes:

Replace x * x with x ** 2 (square-identity)

sourcery-ai · 2023-12-04T15:31:44Z

pxr/base/lib/gf/testenv/testGfPlane.py


 def err( msg ):
-    return "ERROR: " + msg + " failed"
+    return f"ERROR: {msg} failed"


Function err refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:47Z

pxr/base/lib/gf/testenv/testGfPlane.py

-        self.assertTrue(not p1 == p2, err("equality"))
-        self.assertTrue(not p1 != Gf.Plane(Gf.Vec3d(1,1,1), 10), err("inequality"))
+        self.assertTrue(p1 != p2, err("equality"))
+        self.assertTrue(p1 == Gf.Plane(Gf.Vec3d(1,1,1), 10), err("inequality"))


Function TestGfBBox3d.test_Operators refactored with the following changes:

Simplify logical expression using De Morgan identities [×2] (de-morgan)

sourcery-ai · 2023-12-04T15:31:47Z

pxr/base/lib/gf/testenv/testGfQuaternion.py

-        q = q * 10
+        q *= 10
        self.assertEqual(q, Gf.Quaternion(100,Gf.Vec3d(200,300,400)))
-        q = 10 * q
+        q *= 10
        self.assertEqual(q, Gf.Quaternion(1000,Gf.Vec3d(2000,3000,4000)))
        q /= 100
        self.assertEqual(q, Gf.Quaternion(10,Gf.Vec3d(20,30,40)))
-        q = q / 10
+        q /= 10


Function TestGfQuaternion.test_Operators refactored with the following changes:

Replace assignment with augmented assignment [×3] (aug-assign)

sourcery-ai · 2023-12-04T15:31:47Z

pxr/base/lib/gf/testenv/testGfRange.py

-    else:
-        v = Value()
-        for i in range(v.dimension):
-            v[i] = vals[i]
+    v = Value()
+    for i in range(v.dimension):
+        v[i] = vals[i]


Function makeValue refactored with the following changes:

Remove unnecessary else after guard condition (remove-unnecessary-else)

sourcery-ai · 2023-12-04T15:31:47Z

pxr/base/lib/gf/testenv/testGfSize.py

            self.assertIsInstance(Size(), Size)
            self.assertIsInstance(Size(Size()), Size)
-            
+


Function TestGfSize.runTest refactored with the following changes:

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2023-12-04T15:31:48Z

pxr/base/lib/gf/testenv/testGfVec.py

        elif type == 'i':
            return Gf.Vec4i
-    assert False, "No valid conversion for " + vecType + " to type " + type
+    assert False, f"No valid conversion for {vecType} to type {type}"


Function vecWithType refactored with the following changes:

Simplify conditional into switch-like form [×12] (switch)

Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:49Z

pxr/base/lib/tf/testenv/testTfFileUtils.py

-        self.assertTrue(os.path.isfile("%s/a" % rootDir))
-        self.assertTrue(os.path.isfile("%s/b" % rootDir))
-        self.assertTrue(os.path.isfile("%s/c" % rootDir))
+        self.assertTrue(os.path.isfile(f"{rootDir}/a"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/b"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/c"))

-        self.assertTrue(os.path.isfile("%s/sub1/a" % rootDir))
-        self.assertTrue(os.path.isfile("%s/sub1/b" % rootDir))
-        self.assertTrue(os.path.isfile("%s/sub1/c" % rootDir))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub1/a"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub1/b"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub1/c"))

-        self.assertTrue(os.path.isfile("%s/sub2/a" % rootDir))
-        self.assertTrue(os.path.isfile("%s/sub2/b" % rootDir))
-        self.assertTrue(os.path.isfile("%s/sub2/c" % rootDir))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub2/a"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub2/b"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub2/c"))

-        self.assertTrue(os.path.isfile("%s/sub3/a" % rootDir))
-        self.assertTrue(os.path.isfile("%s/sub3/b" % rootDir))
-        self.assertTrue(os.path.isfile("%s/sub3/c" % rootDir))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub3/a"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub3/b"))
+        self.assertTrue(os.path.isfile(f"{rootDir}/sub3/c"))


Function TestFileUtils.VerifyDirAndFileStructure refactored with the following changes:

Replace interpolated string formatting with f-string [×12] (replace-interpolation-with-fstring)

sourcery-ai · 2023-12-04T15:31:49Z

pxr/base/lib/tf/testenv/testTfFileUtils.py

-        self.log.info('%s %s %s' % (
-            mtime, Strftime(mtime), self.Links[0][0]))
+        self.log.info(f'{mtime} {Strftime(mtime)} {self.Links[0][0]}')
        for sp,dp in self.Links:
            mtime = Lstat(dp)
-            self.log.info('%s %s %s -> %s' % (
-                mtime, Strftime(mtime), dp, sp))
+            self.log.info(f'{mtime} {Strftime(mtime)} {dp} -> {sp}')


Function TestFileUtils.PrintTestLinks refactored with the following changes:

Replace interpolated string formatting with f-string [×2] (replace-interpolation-with-fstring)

sourcery-ai · 2023-12-04T15:31:49Z

pxr/base/lib/tf/testenv/testTfPython.py


 def f4(stringArg):
-    return 'got string ' + stringArg
+    return f'got string {stringArg}'


Function f4 refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-12-04T15:31:49Z

pxr/base/lib/tf/testenv/testTfPython.py

-        self.assertTrue(1 == Tf._Enum.One)
-        self.assertTrue(2 == Tf._Enum.Two)
-        self.assertTrue(3 == Tf._Alpha)
+        self.assertTrue(Tf._Enum.One == 1)
+        self.assertTrue(Tf._Enum.Two == 2)
+        self.assertTrue(Tf._Alpha == 3)


Function TestPython.test_EnumValuesRemovedFromTypeScope refactored with the following changes:

Ensure constant in comparison is on the right [×3] (flip-comparison)

sourcery-ai · 2023-12-04T15:31:49Z

pxr/base/lib/tf/testenv/testTfScriptModuleLoader.py

 Tf.Debug.SetDebugSymbolsByName('TF_SCRIPT_MODULE_LOADER', True)

-prefix = Tf.__package__ + '.testenv.testTfScriptModuleLoader_'
+prefix = f'{Tf.__package__}.testenv.testTfScriptModuleLoader_'


Lines 46-46 refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai

PR Type: Refactoring

Summary of PR: This PR includes changes made by the Sourcery tool to refactor the codebase. It primarily consists of using more concise Python syntax such as the walrus operator for simultaneous assignment and evaluation, generator expressions, and f-strings for string formatting. The changes aim to improve the code's efficiency and readability.

General PR suggestions:

Ensure that the use of the walrus operator does not compromise code readability, especially for those who may not be familiar with this newer Python syntax.
Verify that changes in logic, particularly where conditions are combined or checks are omitted, do not introduce bugs or alter the intended behavior of the code.
Remove unnecessary parentheses that do not contribute to code clarity and are not required by Python syntax.
Consider the impact of using set literals on the significance of the order of elements, and use lists or tuples if the order is important.
Eliminate semicolons at the end of Python statements, as they are not needed and are not idiomatic in Python.
Review the changes to ensure that they align with the project's style guide and maintain the codebase's overall consistency.

Your trial expires on December 18, 2023. Please email tim@sourcery.ai to continue using Sourcery ✨

sourcery-ai · 2023-12-04T15:36:50Z

pxr/usdImaging/lib/usdviewq/appController.py

-            viewerMode = self.stateProperty("viewerMode", default=False)
-
-            if viewerMode:
+            if viewerMode := self.stateProperty("viewerMode", default=False):


suggestion (llm): Using the walrus operator for assignment and condition check is concise, but it may reduce readability for those unfamiliar with the syntax. Consider if readability is a priority over brevity in this context.

Suggested change

if viewerMode := self.stateProperty("viewerMode", default=False):

viewerMode = self.stateProperty("viewerMode", default=False)

if viewerMode:

sourcery-ai · 2023-12-04T15:36:50Z

pxr/usdImaging/lib/usdviewq/appController.py

+        if self.realStartTimeCode is None or self.realEndTimeCode is None:
            self._timeSamples = []

+        elif self.realStartTimeCode > self.realEndTimeCode:


issue (llm): The refactoring changes the logic of the time samples update. Previously, the check for 'None' values was separate from the range check, which is now combined. This could lead to a situation where '_timeSamples' is not cleared if only one of 'realStartTimeCode' or 'realEndTimeCode' is 'None'.

Suggested change

elif self.realStartTimeCode > self.realEndTimeCode:

if self.realStartTimeCode is None or self.realEndTimeCode is None or self.realStartTimeCode > self.realEndTimeCode:

sourcery-ai · 2023-12-04T15:36:50Z

pxr/usdImaging/lib/usdviewq/appController.py

-        # Process some more prim view items.
-        n = min(100, len(self._itemsToPush))
-        if n:
+        if n := min(100, len(self._itemsToPush)):


suggestion (llm): While the use of the walrus operator here is compact, it may be less clear that 'n' is intended to be used beyond the scope of the 'if' statement. Consider declaring 'n' before the 'if' statement for clarity.

Suggested change

if n := min(100, len(self._itemsToPush)):

n = min(100, len(self._itemsToPush))

if n:

sourcery-ai · 2023-12-04T15:36:50Z

pxr/usdImaging/lib/usdviewq/appController.py

            bottomHeight = 0
            stageViewWidth += primViewWidth
            primViewWidth = 0
+        elif self._viewerModeEscapeSizes is None:


issue (llm): The refactored code changes the behavior when '_viewerModeEscapeSizes' is 'None'. Previously, the 'else' block would always execute if '_viewerModeEscapeSizes' is 'None', but now it only executes if both 'self._viewerMode' and '_viewerModeEscapeSizes' are 'None'. This could lead to unintended behavior.

Suggested change

elif self._viewerModeEscapeSizes is None:

if self._viewerModeEscapeSizes is None or not self._viewerMode:

sourcery-ai · 2023-12-04T15:36:51Z

pxr/usd/lib/usd/usdGenSchema.py

                       'https://graphics.pixar.com/usd/docs/api/'
                       '_usd__page__generating_schemas.html '
                       'for more information.\n')
+        errorPrefix = (


nitpick (llm): The refactoring introduces additional parentheses that are not necessary and could be removed for cleaner code.

sourcery-ai · 2023-12-04T15:36:51Z

pxr/usd/lib/usd/testenv/testUsdStage.py

            assert attr.Get() == 'from_session'
-            assert (set(stage.GetUsedLayers()) ==
-                    set([sublayer_1, sublayer_2, sessionLayer, rootLayer]))
+            assert set(stage.GetUsedLayers()) == {


suggestion (llm): While using set literals is more performant and readable, ensure that the order of the layers is not significant. If the order matters, a list or tuple might be more appropriate.

sourcery-ai · 2023-12-04T15:36:51Z

pxr/usdImaging/lib/usdviewq/appController.py

        title = self._mainWindow.windowTitle()
        if title[-1] != '*':
-            self._mainWindow.setWindowTitle(title + ' *')
+            self._mainWindow.setWindowTitle(f'{title} *')


praise (llm): Good use of f-string for string formatting, which is more readable and efficient.

'Refactored by Sourcery'

ad44afe

sourcery-ai bot requested a review from tatstratasys December 4, 2023 15:31

sourcery-ai bot commented Dec 4, 2023

View reviewed changes

		AssertDeterminant(m1 * m1, det1 * det1)
		AssertDeterminant(m1 * m1, det1**2)

		self.assertIsInstance(Size(), Size)
		self.assertIsInstance(Size(Size()), Size)

	if viewerMode := self.stateProperty("viewerMode", default=False):
	viewerMode = self.stateProperty("viewerMode", default=False)
	if viewerMode:

	elif self.realStartTimeCode > self.realEndTimeCode:
	if self.realStartTimeCode is None or self.realEndTimeCode is None or self.realStartTimeCode > self.realEndTimeCode:

	if n := min(100, len(self._itemsToPush)):
	n = min(100, len(self._itemsToPush))
	if n:

	elif self._viewerModeEscapeSizes is None:
	if self._viewerModeEscapeSizes is None or not self._viewerMode:

Sourcery refactored master branch #1

Are you sure you want to change the base?

Sourcery refactored master branch #1

Uh oh!

Conversation

sourcery-ai bot commented Dec 4, 2023

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2023