This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Treat content as HTML even if it has junk before the start of the HTML#98
Open
gnp wants to merge 2 commits intoGravityLabs:masterfrom
Open
Treat content as HTML even if it has junk before the start of the HTML#98gnp wants to merge 2 commits intoGravityLabs:masterfrom
gnp wants to merge 2 commits intoGravityLabs:masterfrom
Conversation
…e the implementation more efficient.
Author
|
I have JDK 8 installed, and I had to invoke Maven like this: else I got compiler complaints about JDK classfiles being "broken". |
Author
|
With some refactoring to split out the parsing from the fetching in HtmlFetcher.scala, it would be possible to write unit tests that exercise the different cases, including the one I built this for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen pages like this in the wild, for example with
<script>stuff before the HTML doctype stuff. This fallback helped me still be able to run Goose on those pages.