Free the image resource when the owner is deallocated #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahagr
reviewed
Jun 14, 2018
mahagr
left a comment
mahagr
left a comment
There was a problem hiding this comment.
I don't think this is a good idea. Destruct will remove the reference from the resource and free it in GC anyway.
| public function __destruct() | ||
| { | ||
| if (null !== $this->resource) | ||
| imagedestroy($this->resource); |
There was a problem hiding this comment.
I cannot recommend using imagedestroy() as the resource may have been used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.