fix[next]: symbol clash in inline_lambda #2134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes the bug in #1713 |
philip-paul-mueller
pushed a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Jul 15, 2025
Before this PR `(λ(x, y) → f(x, x + y))(y + y, x)` with `opcount_preserving=True` would inline to `(λ(x) → f(x, x + x))(y + y)` because the outer `x` vs the lambda parameter `x` was not properly handled. Now, in case of such a conflict, the lambda is first transformed to `λ(x_, y) → f(x_, x_ + y)`.
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
Before this PR `(λ(x, y) → f(x, x + y))(y + y, x)` with `opcount_preserving=True` would inline to `(λ(x) → f(x, x + x))(y + y)` because the outer `x` vs the lambda parameter `x` was not properly handled. Now, in case of such a conflict, the lambda is first transformed to `λ(x_, y) → f(x_, x_ + y)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
(λ(x, y) → f(x, x + y))(y + y, x)withopcount_preserving=Truewould inline to(λ(x) → f(x, x + x))(y + y)because the outerxvs the lambda parameterxwas not properly handled.Now, in case of such a conflict, the lambda is first transformed to
λ(x_, y) → f(x_, x_ + y).