refactor[next]: Add config variable GT4PY_ENABLE_GPU_TRACE
#2440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iomaganaris
approved these changes
Jan 16, 2026
Contributor
iomaganaris
left a comment
iomaganaris
left a comment
There was a problem hiding this comment.
Thanks for doing this properly 👍
egparedes
changed the title
GT4PY_ENABLE_GPU_TRACEGT4PY_ENABLE_GPU_TRACE
egparedes
reviewed
Jan 16, 2026
| ) | ||
|
|
||
| if (config.COLLECT_METRICS_LEVEL == metrics.GPU_TX_MARKERS) and gpu: | ||
| if gpu and config.ENABLE_GPU_TRACE: |
Contributor
There was a problem hiding this comment.
How does this interact with the workflow cache(s) key(s)? I mean the code generated with traces should have a key in the cached steps different than the code generated without traces, but it doesn't seem to be any state in the code generator tracking this...
Contributor
Author
There was a problem hiding this comment.
As discussed offline, it is a limitation the cache in gt4py-next. The same limitation applies to other configuration options such as CMAKE_BUILD_TYPE and UNSTRUCTURED_HORIZONTAL_HAS_UNIT_STRIDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not add any new feature, it only changes the way to enable an existing feature introduced in #2345.
The
COLLECT_METRICS_LEVELis supposed to be a runtime configuration, to enable or disable collection of the metrics. Besides, the current GPU trace is not producing any metric.The NVTX/ROC-TX traces require to introduce some calls in the generated code. Therefore we need a separate configuration variable, to be checked at lowering/compile time, to allow the user to introduce the GPU TX markers in the generated code.