chore: add Dependabot config and security policy#1
Merged
Conversation
- Dependabot: weekly updates for Go modules and GitHub Actions - SECURITY.md: responsible disclosure via GitHub Security Advisories
GitHub Actions runners have Go 1.25.6 — go.mod requiring 1.25.7 caused golangci-lint to fail with GOTOOLCHAIN=local.
- errcheck: handle f.Close() and resp.Body.Close() return values - errcheck: use errWriter in markdown reporter to track write errors - ineffassign: remove unused pct variable in prometheus collector - unused: remove dead code (newAWSProviderForTest, queryCPURateInstant, queryMemoryInstant, mockProvider in orchestrator_test) - staticcheck: suppress SA1019 for fake.NewSimpleClientset (replacement NewClientset requires generated apply configs not available here) - ci: lower go directive to 1.25.0 for GitHub runner compatibility
76fb69e to
cd7f817
Compare
DRY: - Extract SumEffectiveResources() in model, remove duplicate in simulation/bfd.go KISS: - Remove dead http.Get call in detectBackend (result was unused) Constants: - Simulation thresholds: HighUtilThreshold, LowUtilThreshold, CriticalMemUtilThreshold, HighSpotRatio - Prometheus: pingTimeout, defaultStep, minEffectiveCPUMillis, minEffectiveMemoryBytes - AWS: defaultMaxPods, eksMaxPods Also fixes remaining errcheck issues in inspect, pricing, orchestrator and report/table (missed in prior lint fix commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Setting up the repo with standard OSS practices now that branch protection is enabled.