This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Memoize results of parsing, normalization, and stringification #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the approach taken in dchester#75.
It does result in significant speedup, as the author suggests. It utilizes Underscore's
memoizefunction: https://underscorejs.org/#memoizeThis could result in memory issues if clients have a large number of dynamically generated JSON paths, but we currently have no such use cases. All our JSON paths are static. This affects caching only, not functionality, so it is covered by existing tests cases.
A better long-term approach might be to allow users of this library to pre-parse expressions and then pass them into functions that take the AST instead of string paths, but that's a bigger lift.