-
Notifications
You must be signed in to change notification settings - Fork 3
Improve batching #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve batching #409
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 95.54% 95.57% +0.02%
==========================================
Files 29 29
Lines 1438 1468 +30
==========================================
+ Hits 1374 1403 +29
- Misses 64 65 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Running the attached card (full DIS) with in main takes: while in the PR takes Giving identical results. |
vschutze-alt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some small changes to the documentation. Other than that, it looks good to me.
This PR improves batching addressing the issue #404 .
The idea is that it precomputes the inv covmats if batching is fixed. Also, it allows to choose the option to change batches at each epoch.
Data batches can be controlled from the runcard with the following options:
Main implementations: