feat(client): allow to disable server cert verification on dangerous feature for all http version#1175
Open
feat(client): allow to disable server cert verification on dangerous feature for all http version#1175
Conversation
joelwurtz
force-pushed
the
feat/allow-invalid-certificate
branch
from
834b9fa to
2c8ad5a
Compare
joelwurtz
force-pushed
the
feat/allow-invalid-certificate
branch
from
2c8ad5a to
e81aca9
Compare
Collaborator
|
What do you think if we add a I can work on the module making integration to this PR easier |
Contributor
Author
|
Sure, we could also use a marker system like other struct in xitca and restrict those feature to builder having this marker |
…feature for all http version
joelwurtz
force-pushed
the
feat/allow-invalid-certificate
branch
from
e81aca9 to
13a1ad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the dangerous feature which add a new method to the client allowing invalid certificates, could be useful in trusted network / test environment and simplify process for end user.
It changes the current behavior for http3 where before it was always allowing invalidate certificate when feature was enable, now it requires both feature and config option to be set to allow this.